chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h - Issue 10831008: Refactor and fix declarative webRequest API permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h

Issue 10831008: Refactor and fix declarative webRequest API permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Nits Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative_webrequest/webrequest_action.h ('K') | « chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.cc ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc » ('j') | chrome/browser/extensions/api/web_request/web_request_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h

index 55f0083c79b767e8278df1862376cb0abea7d6f4..43439c7c7d4e24a4d412014d8e2273ae9f875aab 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h

@@ -20,6 +20,7 @@

#include "chrome/common/extensions/matcher/url_matcher.h"

class Profile;

+class WebRequestPermissions;

namespace extension_web_request_api_helpers {

struct EventResponseDelta;

@@ -74,8 +75,10 @@ class WebRequestRulesRegistry : public RulesRegistryWithCache {

// Returns which modifications should be executed on the network request

// according to the rules registered in this registry.

std::list<LinkedPtrEventResponseDelta> CreateDeltas(

+ const WebRequestPermissions* permissions,

const ExtensionInfoMap* extension_info_map,

net::URLRequest* request,

+ bool crosses_incognito,

RequestStages request_stage,

const WebRequestRule::OptionalRequestData& optional_request_data);