Refactor and fix declarative webRequest API permissions

chrome/browser/extensions/api/declarative/rules_registry_service.cc

Index: chrome/browser/extensions/api/declarative/rules_registry_service.cc
diff --git a/chrome/browser/extensions/api/declarative/rules_registry_service.cc b/chrome/browser/extensions/api/declarative/rules_registry_service.cc
index aead2a977fc688213a2a0fee607abecc26e9dd93..a72fa33aeee6bc3b7c335aad273273d8dcc430bc 100644
--- a/chrome/browser/extensions/api/declarative/rules_registry_service.cc
+++ b/chrome/browser/extensions/api/declarative/rules_registry_service.cc
@@ -22,15 +22,20 @@ namespace extensions {
 namespace {
 
 // Returns the key to use for storing declarative rules in the state store.
-std::string GetDeclarativeRuleStorageKey(const std::string& event_name) {
-  return "declarative_rules." + event_name;
+std::string GetDeclarativeRuleStorageKey(const std::string& event_name,
+                                         bool incognito) {
+  if (incognito)
+    return "declarative_rules.incognito." + event_name;
+  else
+    return "declarative_rules." + event_name;
 }
 
 // Registers |web_request_rules_registry| on the IO thread.
 void RegisterToExtensionWebRequestEventRouterOnIO(
+    void* profile,
     scoped_refptr<WebRequestRulesRegistry> web_request_rules_registry) {
   ExtensionWebRequestEventRouter::GetInstance()->RegisterRulesRegistry(
-      web_request_rules_registry);
+      profile, web_request_rules_registry);
 }
 
 }  // namespace
@@ -48,13 +53,13 @@ RulesRegistryService::~RulesRegistryService() {
     delegates_[i]->CleanupOnUIThread();
 }
 
-void RulesRegistryService::RegisterDefaultRulesRegistries() {
+void RulesRegistryService::RegisterDefaultRulesRegistries(bool incognito) {

[Matt Perry, 2012/07/25 21:27:56]

The incognito parameter is redundant. You can just check
profile_->IsOffTheRecord()

[battre, 2012/07/26 16:38:43]

Done.

   RulesRegistryStorageDelegate* delegate = new RulesRegistryStorageDelegate();
   scoped_refptr<WebRequestRulesRegistry> web_request_rules_registry(
       new WebRequestRulesRegistry(profile_, delegate));
   delegate->InitOnUIThread(profile_, web_request_rules_registry,
       GetDeclarativeRuleStorageKey(
-          declarative_webrequest_constants::kOnRequest));
+          declarative_webrequest_constants::kOnRequest, incognito));
   delegates_.push_back(delegate);
 
   RegisterRulesRegistry(declarative_webrequest_constants::kOnRequest,
@@ -62,14 +67,14 @@ void RulesRegistryService::RegisterDefaultRulesRegistries() {
   content::BrowserThread::PostTask(
       content::BrowserThread::IO, FROM_HERE,
       base::Bind(&RegisterToExtensionWebRequestEventRouterOnIO,
-          web_request_rules_registry));
+          profile_, web_request_rules_registry));
 }
 
 void RulesRegistryService::Shutdown() {
   content::BrowserThread::PostTask(
       content::BrowserThread::IO, FROM_HERE,
       base::Bind(&RegisterToExtensionWebRequestEventRouterOnIO,
-          scoped_refptr<WebRequestRulesRegistry>(NULL)));
+          profile_, scoped_refptr<WebRequestRulesRegistry>(NULL)));
 }
 
 void RulesRegistryService::RegisterRulesRegistry(