Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/browser/metrics/metrics_service.h

Issue 10830318: Use a different algorithm with the low entropy source for field trials. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service.h
===================================================================
--- chrome/browser/metrics/metrics_service.h (revision 151948)
+++ chrome/browser/metrics/metrics_service.h (working copy)
@@ -16,6 +16,7 @@
#include "base/gtest_prod_util.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
+#include "base/metrics/field_trial.h"
#include "base/process_util.h"
#include "chrome/browser/metrics/metrics_log.h"
#include "chrome/browser/metrics/tracking_synchronizer_observer.h"
@@ -38,6 +39,7 @@
namespace base {
class DictionaryValue;
+class EntropyProvider;
Ilya Sherman 2012/08/17 07:34:28 Isn't this class defined as a subtype of the Field
Alexei Svitkine (slow) 2012/08/17 14:08:59 You're right. This got left over from a previous i
class MessageLoopProxy;
}
@@ -86,16 +88,21 @@
// recording is not currently running.
std::string GetClientId();
- // Returns the preferred entropy source used to seed persistent activities
+ // Returns the preferred entropy provider used to seed persistent activities
// based on whether or not metrics reporting will permitted on this client.
// The caller must determine if metrics reporting will be enabled for this
- // client and pass that state in as |reporting_will_be_enabled|. If
- // |reporting_will_be_enabled| is true, this method returns the client ID
- // concatenated with the low entropy source. Otherwise, this method just
- // returns the low entropy source. Note that this reporting state can not be
- // checked by reporting_active() because this method may need to be called
- // before the MetricsService needs to be started.
- std::string GetEntropySource(bool reporting_will_be_enabled);
+ // client and pass that state in as |reporting_will_be_enabled|.
+ //
+ // If |reporting_will_be_enabled| is true, this method returns an entropy
+ // provider that has a high source of entropy, partially based on the client
+ // ID. Otherwise, an entropy provider that is based on a low entropy source
+ // is returned.
+ //
+ // Note that this reporting state can not be checked by reporting_active()
+ // because this method may need to be called before the MetricsService needs
+ // to be started.
+ base::FieldTrial::EntropyProvider* GetEntropyProvider(
+ bool reporting_will_be_enabled);
// Force the client ID to be generated. This is useful in case it's needed
// before recording.

Powered by Google App Engine
This is Rietveld 408576698