Use a different algorithm with the low entropy source for field trials.

chrome/browser/chrome_browser_main_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include <vector>
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "chrome/browser/chrome_browser_main.h"
@@ skipping 15 matching lines @@
  protected:
   TestingPrefService pref_service_;
   CommandLine command_line_;
 };
 
 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_WarmestSocket) {
   command_line_.AppendSwitchASCII(switches::kSocketReusePolicy, "0");
 
   scoped_ptr<content::MainFunctionParams> params(
       new content::MainFunctionParams(command_line_));
   scoped_ptr<content::BrowserMainParts> bw(

[jar (doing other things), 2012/08/17 19:06:19]

nit: use descriptive names, not abbreviations such as |bw|

[Alexei Svitkine (slow), 2012/08/20 15:57:40]

Done.

       content::GetContentClient()->browser()->CreateBrowserMainParts(*params));
   ChromeBrowserMainParts* cbw = static_cast<ChromeBrowserMainParts*>(bw.get());

[jar (doing other things), 2012/08/17 19:06:19]

nit: |cbw| --> descriptive name

[Alexei Svitkine (slow), 2012/08/20 15:57:40]

Done.

   EXPECT_TRUE(cbw);
   if (cbw) {
+    base::FieldTrialList field_trial_list_(NULL);
     cbw->browser_field_trials_.WarmConnectionFieldTrial();
     EXPECT_EQ(0, net::GetSocketReusePolicy());
   }
 }
 
 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_Random) {
   scoped_ptr<content::MainFunctionParams> params(
       new content::MainFunctionParams(command_line_));
   scoped_ptr<content::BrowserMainParts> bw(
       content::GetContentClient()->browser()->CreateBrowserMainParts(*params));
   ChromeBrowserMainParts* cbw = static_cast<ChromeBrowserMainParts*>(bw.get());

[jar (doing other things), 2012/08/17 19:06:19]

nit: use descriptive names for variables (line 50 and 52), as well as later in
file.

[Alexei Svitkine (slow), 2012/08/20 15:57:40]

Done. I didn't write this code, but I shaved the yak at your request.

   EXPECT_TRUE(cbw);
   if (cbw) {
     const int kNumRuns = 1000;
     for (int i = 0; i < kNumRuns; i++) {
+      base::FieldTrialList field_trial_list_(NULL);
       cbw->browser_field_trials_.WarmConnectionFieldTrial();
       int val = net::GetSocketReusePolicy();
       EXPECT_LE(val, 2);
       EXPECT_GE(val, 0);
     }
   }
 }
 #if GTEST_HAS_DEATH_TEST
 TEST_F(BrowserMainTest, WarmConnectionFieldTrial_Invalid) {
   command_line_.AppendSwitchASCII(switches::kSocketReusePolicy, "100");
@@ skipping 16 matching lines @@
 #if defined(NDEBUG) && defined(DCHECK_ALWAYS_ON)
     EXPECT_DEATH(cbw->browser_field_trials_.WarmConnectionFieldTrial(),
                  "Not a valid socket reuse policy group");
 #else
     EXPECT_DEBUG_DEATH(cbw->browser_field_trials_.WarmConnectionFieldTrial(),
                        "Not a valid socket reuse policy group");
 #endif
   }
 }
 #endif