Add GetFilelist/GetFile operations for Drive V2 API.

chrome/browser/chromeos/gdata/gdata_documents_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_DOCUMENTS_SERVICE_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_DOCUMENTS_SERVICE_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 84 matching lines @@
   // Fetches a changelist from |url| with |start_changestamp|, using Drive V2
   // API. If this URL is empty the call will use the default URL. Specify |url|
   // when pagenated request should be issued.
   // |start_changestamp| specifies the starting point of change list or 0 if
   // all changes are necessary.
   // Upon completion, invokes |callback| with results on calling thread.
   virtual void GetChangelist(const GURL& url,
                              int64 start_changestamp,
                              const GetDataCallback& callback) = 0;
 
+  // Fetches a filelist from |url| with |search_query|, using Drive V2 API. If

[satorux1, 2012/08/14 13:17:21]

Do we need to say V2? The public documentation does not seem to say V2?

[kochi, 2012/08/15 04:17:17]

The Drive V1 API is so poor that only file access method
is provided, and no practical application can be written with it. So most
probably Drive API should refer to V2+.
If referring V2 sounds too noisy, I could remove it, but I prefer explicitly
saying we are using V2, not V1 or V3 for
clarity.

+  // this URL is empty the call will use the default URL. Specify |url| when
+  // pagenated request should be issued.
+  // |search_query| specifies query string, whose syntax is described at
+  // https://developers.google.com/drive/search-parameters
+  virtual void GetFilelist(const GURL& url,

[satorux1, 2012/08/14 13:17:21]

GetFileList?

[kochi, 2012/08/15 04:17:18]

This convention is following GetChangelist() above, and
operation name is also GetFilelistOperation.

+                           const std::string& search_query,
+                           const GetDataCallback& callback) = 0;

[satorux1, 2012/08/14 13:17:21]

Would it be difficult to create a new file like drive_api_service.h and put
Drive API stuff there?

gdata_documents_service.h was written for WAPI, adding Drive API code here would
be confusing. It's hard to tell if a function is for WAPI or Drive API.

That said, we should do

- rename gdata_documents_service.h -> gdata_wapi_service.h
- introduce drive_api_service.h

Could you do this in a separate patch? Please also file a bug.

[kochi, 2012/08/15 04:17:18]

Filed http://crbug.com/142809
I'll work on it.

+
   // Fetches single entry metadata from server. The entry's resource id equals
   // |resource_id|.
   // Upon completion, invokes |callback| with results on the calling thread.
   virtual void GetDocumentEntry(const std::string& resource_id,
                                 const GetDataCallback& callback) = 0;
 
+  // Fetches single entry metadata from server. The entry's file id equals
+  // |file_id|.
+  // Upon completion, invokes |callback| with results on the calling thread.

[satorux1, 2012/08/14 13:17:21]

reference URL? Is this also Drive API?

[kochi, 2012/08/15 04:17:18]

Done.

+  virtual void GetFile(const std::string& file_id,
+                       const GetDataCallback& callback) = 0;
+
   // Gets the account metadata from the server using the default account
   // metadata URL. Upon completion, invokes |callback| with results on the
   // calling thread.
   virtual void GetAccountMetadata(const GetDataCallback& callback) = 0;
 
   // Gets the About resource from the server for the current account.
   // Upon completion, invokes |callback| with results on the calling thread.
   // (For Drive V2 API only)
   virtual void GetAboutResource(const GetDataCallback& callback) = 0;
 
@@ skipping 101 matching lines @@
   // DocumentsServiceInterface Overrides
   virtual void Initialize(Profile* profile) OVERRIDE;
   virtual GDataOperationRegistry* operation_registry() const OVERRIDE;
   virtual void CancelAll() OVERRIDE;
   virtual void Authenticate(const AuthStatusCallback& callback) OVERRIDE;
   virtual void GetDocuments(const GURL& feed_url,
                             int start_changestamp,
                             const std::string& search_query,
                             const std::string& directory_resource_id,
                             const GetDataCallback& callback) OVERRIDE;
+  virtual void GetFilelist(const GURL& url,
+                           const std::string& search_query,
+                           const GetDataCallback& callback) OVERRIDE;
   virtual void GetChangelist(const GURL& url,
                              int64 start_changestamp,
                              const GetDataCallback& callback) OVERRIDE;
   virtual void GetDocumentEntry(const std::string& resource_id,
                                 const GetDataCallback& callback) OVERRIDE;
+  virtual void GetFile(const std::string& file_id,
+                       const GetDataCallback& callback) OVERRIDE;
 
   virtual void GetAccountMetadata(const GetDataCallback& callback) OVERRIDE;
   virtual void GetAboutResource(const GetDataCallback& callback) OVERRIDE;
   virtual void GetApplicationList(const GetDataCallback& callback) OVERRIDE;
   virtual void DeleteDocument(const GURL& document_url,
                               const EntryActionCallback& callback) OVERRIDE;
   virtual void DownloadDocument(
       const FilePath& virtual_path,
       const FilePath& local_cache_path,
       const GURL& content_url,
@@ skipping 37 matching lines @@
   Profile* profile_;
 
   scoped_ptr<GDataOperationRunner> runner_;
 
   DISALLOW_COPY_AND_ASSIGN(DocumentsService);
 };
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_DOCUMENTS_SERVICE_H_