[mac] Don't consider kAutoupdateCheckFailed as a permanent failure.

chrome/browser/ui/webui/help/version_updater_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/help/version_updater_mac.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #import "chrome/browser/mac/keystone_glue.h"
@@ skipping 59 matching lines @@
   // Copy the callbacks, we will re-use this for the remaining lifetime
   // of this object.
   status_callback_ = status_callback;
   promote_callback_ = promote_callback;
 
   KeystoneGlue* keystone_glue = [KeystoneGlue defaultKeystoneGlue];
   if (keystone_glue && ![keystone_glue isOnReadOnlyFilesystem]) {
     AutoupdateStatus recent_status = [keystone_glue recentStatus];
     if ([keystone_glue asyncOperationPending] ||
         recent_status == kAutoupdateRegisterFailed ||
-        recent_status == kAutoupdateCheckFailed ||
         recent_status == kAutoupdateInstallFailed ||

[Mark Mentovai, 2012/08/14 02:33:14]

I think that you should remove install-failed for sure, and likely
promote-failed as well. install-failed can be a transient failure just like
check-failed. promote-failed doesn’t necessarily invalidate the possibility that
updates might be applied in the absence of promotion.

[csilv, 2012/08/14 17:32:51]

Done.

         recent_status == kAutoupdatePromoteFailed ||
         recent_status == kAutoupdateNeedsPromotion) {
       // If an asynchronous update operation is currently pending, such as a
       // check for updates or an update installation attempt, set the status
       // up correspondingly without launching a new update check.
       //
       // If registration failed, no other operations make sense, so just go
       // straight to the error.
       UpdateStatus([[keystone_glue recentNotification] userInfo]);
     } else {
@@ skipping 142 matching lines @@
   } else if (recent_status == kAutoupdatePromoting ||
              recent_status == kAutoupdatePromoteFailed) {
     // Show promotion UI because the user either just clicked that button or
     // because the user should be able to click it again.
     show_promote_button_ = true;
   } else {
     // Show the promote button if promotion is a possibility.
     show_promote_button_ = [keystone_glue wantsPromotion];
   }
 }