Issue 10830260: Add local file system directory listings support for content shell.

Issue 10830260: Add local file system directory listings support for content shell. (Closed)

Created:
8 years, 4 months ago by jam

Modified:
8 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add local file system directory listings support for content shell. Also remove the per-platform PlatformResourceProvider function. Based on http://codereview.chromium.org/10826242/ by shouqun.liu@intel.com BUG=90445 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151267

Patch Set 2 : #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -43 lines)			Patch
M	content/content_shell.gypi	View	1	2 chunks	+2 lines, -2 lines	2 comments	Download
M	content/shell/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/shell/shell.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/shell/shell_android.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/shell/shell_aura.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/shell/shell_browser_main_parts.cc	View	1	4 chunks	+17 lines, -1 line	0 comments	Download
M	content/shell/shell_gtk.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/shell/shell_mac.mm	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/shell/shell_win.cc	View		3 chunks	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

lgtm https://chromiumcodereview.appspot.com/10830260/diff/12002/content/content_shell.gypi File content/content_shell.gypi (left): https://chromiumcodereview.appspot.com/10830260/diff/12002/content/content_shell.gypi#oldcode242 content/content_shell.gypi:242: '<(DEPTH)/net/net.gyp:net_resources', why is this move required?

8 years, 4 months ago (2012-08-13 09:43:46 UTC) #2

jam

https://chromiumcodereview.appspot.com/10830260/diff/12002/content/content_shell.gypi File content/content_shell.gypi (left): https://chromiumcodereview.appspot.com/10830260/diff/12002/content/content_shell.gypi#oldcode242 content/content_shell.gypi:242: '<(DEPTH)/net/net.gyp:net_resources', On 2012/08/13 09:43:46, jochen wrote: > why is ...

8 years, 4 months ago (2012-08-13 15:07:25 UTC) #3

jochen (gone - plz use gerrit)

8 years, 4 months ago (2012-08-13 15:11:35 UTC) #4

On 2012/08/13 15:07:25, John Abd-El-Malek wrote:
>
https://chromiumcodereview.appspot.com/10830260/diff/12002/content/content_sh...
> File content/content_shell.gypi (left):
> 
>
https://chromiumcodereview.appspot.com/10830260/diff/12002/content/content_sh...
> content/content_shell.gypi:242: '<(DEPTH)/net/net.gyp:net_resources',
> On 2012/08/13 09:43:46, jochen wrote:
> > why is this move required?
> 
> in patchset 1, I tried putting net.gyp:net_resources just in the windows
section
> beside the other resources (since for posix it was already here). but then all
> posix builds failed compile because they couldn't resolve the
> grit/net_resources.h include

sg

Expand Messages | Collapse Messages