Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10830256: Check ignore-certificate-erros in SocketStream (Closed)

Created:
8 years, 4 months ago by bashi
Modified:
8 years, 4 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Takashi Toyoshima
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Check ignore-certificate-erros in SocketStream WebSocket should ignore certificate errors when chromium starts with --ignore-certificate-erros flag. BUG=141762 TEST=SSLUITestIgnoreCertErrors.TestWSS Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151208

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 chunks +42 lines, -0 lines 0 comments Download
M net/socket_stream/socket_stream.cc View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bashi
yutak@: socket_stream.cc sky@: ssl_browser_tests.cc Could you take a look?
8 years, 4 months ago (2012-08-10 06:02:49 UTC) #1
bashi
+jcivelli for ssl test. Looks like he LGTM'ed similar CL. http://codereview.chromium.org/9959062#msg7
8 years, 4 months ago (2012-08-10 06:10:12 UTC) #2
Yuta Kitamura
LGTM with a nit. http://codereview.chromium.org/10830256/diff/1/chrome/browser/ssl/ssl_browser_tests.cc File chrome/browser/ssl/ssl_browser_tests.cc (right): http://codereview.chromium.org/10830256/diff/1/chrome/browser/ssl/ssl_browser_tests.cc#newcode1480 chrome/browser/ssl/ssl_browser_tests.cc:1480: std::string urlPath = url_path
8 years, 4 months ago (2012-08-10 06:56:24 UTC) #3
sky
LGTM https://chromiumcodereview.appspot.com/10830256/diff/1/chrome/browser/ssl/ssl_browser_tests.cc File chrome/browser/ssl/ssl_browser_tests.cc (right): https://chromiumcodereview.appspot.com/10830256/diff/1/chrome/browser/ssl/ssl_browser_tests.cc#newcode1462 chrome/browser/ssl/ssl_browser_tests.cc:1462: IN_PROC_BROWSER_TEST_F(SSLUITestIgnoreCertErrors, TestWSS) { Add a description as to ...
8 years, 4 months ago (2012-08-10 15:54:47 UTC) #4
bashi
Thank you for review. http://codereview.chromium.org/10830256/diff/1/chrome/browser/ssl/ssl_browser_tests.cc File chrome/browser/ssl/ssl_browser_tests.cc (right): http://codereview.chromium.org/10830256/diff/1/chrome/browser/ssl/ssl_browser_tests.cc#newcode1462 chrome/browser/ssl/ssl_browser_tests.cc:1462: IN_PROC_BROWSER_TEST_F(SSLUITestIgnoreCertErrors, TestWSS) { On 2012/08/10 ...
8 years, 4 months ago (2012-08-12 23:13:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/10830256/8002
8 years, 4 months ago (2012-08-12 23:13:16 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 00:27:28 UTC) #7 
Change committed as 151208

Powered by Google App Engine
This is Rietveld 408576698