chrome/common/extensions/docs/server2/intro_data_source.py - Issue 10830252: Extensions Docs Server: Uniform handling of file not found errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/intro_data_source.py

Issue 10830252: Extensions Docs Server: Uniform handling of file not found errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: better error handling/slight template fix to pass integration_test Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/docs/server2/intro_data_source.py

diff --git a/chrome/common/extensions/docs/server2/intro_data_source.py b/chrome/common/extensions/docs/server2/intro_data_source.py

index 76b18eb49e38a62ee9dfc7f58b585458282f42c4..14315ad784ed4b9026699b46a986c3f166278ee1 100644

--- a/chrome/common/extensions/docs/server2/intro_data_source.py

+++ b/chrome/common/extensions/docs/server2/intro_data_source.py

@@ -82,5 +82,4 @@ class IntroDataSource(object):

return self._cache.GetFromFile(base_path + '/' + real_path)

except FileNotFoundError as error:

pass

- logging.error(error)

- return None

+ raise ValueError(str(error) + ': No intro found for "%s".' % key)