chrome/common/extensions/docs/server2/subversion_file_system.py - Issue 10830252: Extensions Docs Server: Uniform handling of file not found errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/subversion_file_system.py

Issue 10830252: Extensions Docs Server: Uniform handling of file not found errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/docs/server2/subversion_file_system.py

diff --git a/chrome/common/extensions/docs/server2/subversion_file_system.py b/chrome/common/extensions/docs/server2/subversion_file_system.py

index b5d26429776543cff0e0a62ed5ec4791ec4d89dc..354c68981a2c3de6f5125989939c00545b887917 100644

--- a/chrome/common/extensions/docs/server2/subversion_file_system.py

+++ b/chrome/common/extensions/docs/server2/subversion_file_system.py

@@ -42,7 +42,7 @@ class _AsyncFetchFuture(object):

for path, future in self._fetches:

result = future.Get()

if result.status_code == 404:

- self._value[path] = None

+ raise file_system.FileNotFoundError(path)

elif path.endswith('/'):

self._value[path] = self._ListDir(result.content)

elif not self._binary: