Extensions Docs Server: Uniform handling of file not found errors

chrome/common/extensions/docs/server2/intro_data_source.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from HTMLParser import HTMLParser
 import re
 
 from docs_server_utils import FormatKey
+from file_system import FileNotFoundError
 from third_party.handlebar import Handlebar
 
 class _IntroParser(HTMLParser):
   """ An HTML parser which will parse table of contents and page title info out
   of an intro.
   """
   def __init__(self):
     HTMLParser.__init__(self)
     self.toc = []
     self.page_title = None
@@ skipping 51 matching lines @@
     }
 
   def __getitem__(self, key):
     return self.get(key)
 
   def get(self, key):
     real_path = FormatKey(key)
     for base_path in self._base_paths:
       try:
         return self._cache.GetFromFile(base_path + '/' + real_path)
-      except Exception:
+      except FileNotFoundError:
         pass
     return None

[not at google - send to devlin, 2012/08/10 06:12:16]

log error before returning None?

[cduvall, 2012/08/10 17:25:16]

Done.

[not at google - send to devlin, 2012/08/12 22:22:58]

Like ApiListDataSource, this should only be happening if we make a mistake
writing the templates. So rather than logging and returning None, throw a
ValueError if it isn't found?

Btw by "logging error" here I mean like logging.error("No intro found"). Logging
the last error might be misleading.

... though should raise ValueError("No intro found for \"%s\"" % key) anyway.

[cduvall, 2012/08/13 18:44:05]

Done.