Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 10830204: Browser Plugin: Rename old colliding files to old_*. (Closed)

Created:
8 years, 4 months ago by Fady Samuel
Modified:
8 years, 4 months ago
Reviewers:
Charlie Reis, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rjkroege
Visibility:
Public.

Description

Browser Plugin: Rename old colliding files to old_*. Some builds don't like two files in a project with the same name. This addresses the issue. BUG=140306 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150498

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -770 lines) Patch
D content/browser/browser_plugin/old/browser_plugin_host.h View 1 chunk +0 lines, -136 lines 0 comments Download
D content/browser/browser_plugin/old/browser_plugin_host.cc View 1 chunk +0 lines, -239 lines 0 comments Download
D content/browser/browser_plugin/old/browser_plugin_host_helper.h View 1 chunk +0 lines, -53 lines 0 comments Download
D content/browser/browser_plugin/old/browser_plugin_host_helper.cc View 1 chunk +0 lines, -63 lines 0 comments Download
A + content/browser/browser_plugin/old/old_browser_plugin_host.h View 2 chunks +3 lines, -3 lines 1 comment Download
A + content/browser/browser_plugin/old/old_browser_plugin_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/browser_plugin/old/old_browser_plugin_host_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/browser_plugin/old/old_browser_plugin_host_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M content/content_renderer.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
D content/renderer/browser_plugin/old/browser_plugin.h View 1 chunk +0 lines, -94 lines 0 comments Download
D content/renderer/browser_plugin/old/browser_plugin.cc View 1 chunk +0 lines, -162 lines 0 comments Download
M content/renderer/browser_plugin/old/browser_plugin_channel_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/browser_plugin/old/old_browser_plugin.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/renderer/browser_plugin/old/old_browser_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Fady Samuel
8 years, 4 months ago (2012-08-07 22:59:41 UTC) #1
Fady Samuel
Adding creis@ to review as suggested by jam@.
8 years, 4 months ago (2012-08-07 23:22:53 UTC) #2
Charlie Reis
LGTM. Which builds had trouble with the duplicate file names? http://codereview.chromium.org/10830204/diff/1/content/browser/browser_plugin/old/old_browser_plugin_host.h File content/browser/browser_plugin/old/old_browser_plugin_host.h (right): http://codereview.chromium.org/10830204/diff/1/content/browser/browser_plugin/old/old_browser_plugin_host.h#newcode37 ...
8 years, 4 months ago (2012-08-07 23:58:28 UTC) #3
Fady Samuel
On 2012/08/07 23:58:28, creis wrote: > LGTM. Which builds had trouble with the duplicate file ...
8 years, 4 months ago (2012-08-08 00:41:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10830204/1
8 years, 4 months ago (2012-08-08 00:41:47 UTC) #5
commit-bot: I haz the power
Try job failure for 10830204-1 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-08 02:02:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10830204/1
8 years, 4 months ago (2012-08-08 02:13:17 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 04:40:15 UTC) #8
Change committed as 150498

Powered by Google App Engine
This is Rietveld 408576698