chrome/browser/chromeos/gdata/gdata_cache_metadata.cc - Issue 10830181: Implement initialization for GDataCache to use in-memory metadata for tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/gdata/gdata_cache_metadata.cc

Issue 10830181: Implement initialization for GDataCache to use in-memory metadata for tests. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/gdata/gdata_cache_metadata.h ('K') | « chrome/browser/chromeos/gdata/gdata_cache_metadata.h ('k') | chrome/browser/chromeos/gdata/gdata_cache_metadata_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/gdata/gdata_cache_metadata.cc

diff --git a/chrome/browser/chromeos/gdata/gdata_cache_metadata.cc b/chrome/browser/chromeos/gdata/gdata_cache_metadata.cc

index d10829eaa27c5cad968ddb126a692648178bf529..3df82696491d17c65776cd91d365bea5aaf0cddd 100644

--- a/chrome/browser/chromeos/gdata/gdata_cache_metadata.cc

+++ b/chrome/browser/chromeos/gdata/gdata_cache_metadata.cc

@@ -591,9 +591,12 @@ GDataCacheMetadata::~GDataCacheMetadata() {

// static

scoped_ptr<GDataCacheMetadata> GDataCacheMetadata::CreateGDataCacheMetadata(

achuithb 2012/08/06 23:22:20 It may be better to write a separate function like

satorux1 2012/08/07 10:50:08 agreed!

Haruki Sato 2012/08/08 05:00:42 Done!

- base::SequencedTaskRunner* blocking_task_runner) {

- return scoped_ptr<GDataCacheMetadata>(

- new GDataCacheMetadataDB(blocking_task_runner));

+ base::SequencedTaskRunner* blocking_task_runner, bool use_map) {

+ return use_map ?

+ scoped_ptr<GDataCacheMetadata>(

+ new GDataCacheMetadataMap(blocking_task_runner)) :

+ scoped_ptr<GDataCacheMetadata>(

+ new GDataCacheMetadataDB(blocking_task_runner));

}

void GDataCacheMetadata::AssertOnSequencedWorkerPool() {