[Mac]: Make dictionary context menu item use system settings for whether to launch Dictionary.app o…

[Mac]: Make dictionary context menu item use system settings for whether to launch Dictionary.app or show a panel.

BUG=65537, 121917
TEST=Open Dictionary.app's preferences and change "Contextual Menu:" to "Open Dictionary Panel".
Select a word in the web content area, right click and choose "Look Up in Dictionary". The
dictionary panel should appear with the overlay text positioned correctly over the word.
Change the setting back in Dictionary.app and observe that choosing "Look Up in Dictionary"
brings up Dictionary.app in that case.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150388

[Nico, 2012-08-04 02:34:02]

LGTM with fixed bots

You can probably add 121917 to the BUG= line, since I believe this is half of
the async dictionary gesture implementation for 10.8+. See the last comment on
that bug on how to do the second half, if you want to do that.

http://codereview.chromium.org/10830176/diff/1/content/browser/renderer_host/...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/10830176/diff/1/content/browser/renderer_host/...
content/browser/renderer_host/render_widget_host_view_mac.mm:1418: rect.origin.y
+= rect.size.height - [font ascender];
NSHeight(rect)

(NSFont seems to return view units here, not pixels)

[Alexei Svitkine (slow), 2012-08-06 13:35:54]

+avi for content/

[Avi (use Gerrit), 2012-08-07 14:18:30]

Nitting on the comment; LGTM.

http://codereview.chromium.org/10830176/diff/5003/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/10830176/diff/5003/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_mac.mm:1415: // Set
|rect.origin| to the text baseline based on |attr_string|'s font.
Nice cheat! Can you acknowledge in the comment that we do this because we don't
implement -baselineDeltaForCharacterAtIndex:?

[Alexei Svitkine (slow), 2012-08-07 15:17:51]

Nit addressed.

[commit-bot: I haz the power, 2012-08-07 17:34:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10830176/7003

[commit-bot: I haz the power, 2012-08-07 19:17:16]

Change committed as 150388