Added a new test which aims to be really, really mean to WebRTC. Hopefully this will cover some cra…

Added a new test which aims to be really, really mean to WebRTC. Hopefully this will cover some crashes we have fixed recently.


BUG=
NOTRY=True

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150312

[phoglund_chromium, 2012-08-03 12:36:28]

Hi!

This patch adds some rather mean tests for WebRTC. I had to pull some code into
the webrtc test base. Then I added some fairly simple test cases which aim to
disrupt WebRTC at inconvenient times.

This patch supersedes http://codereview.chromium.org/10696115/.

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
File chrome/test/functional/webrtc_call.py (right):

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_call.py:142: self.GetUserMedia(tab_index=0,
action='dismiss'))
I pulled GetUserMedia up into the base class since the new test needed it.

[Nirnimesh, 2012-08-03 18:32:13]

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
File chrome/test/functional/webrtc_brutality_test.py (right):

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_brutality_test.py:4: # found in the LICENSE file.
Leave a blank line after this

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_brutality_test.py:7: 
need another blank line here

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_brutality_test.py:9: """This test class tests how
WebRTC deals with inconvenient reloads, etc."""
Remove "This test class"
It's redundant

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_brutality_test.py:24: tab =
self.GetBrowserWindow(0).GetTab(0)
This format has been deprecated. Use the ReloadTab() call please.

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_brutality_test.py:53: tab.Reload()
ditto

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_brutality_test.py:75: 'getUserMedia(true, true)',
tab_index=0))
indent by 2 more spaces

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
File chrome/test/functional/webrtc_test_base.py (right):

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_test_base.py:13: """Acquires webcam or mic for one
tab and returns the result."""
Add Args  &  Returns: section. Describe what the result is

[phoglund_chromium, 2012-08-06 15:02:18]

PTAL

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
File chrome/test/functional/webrtc_brutality_test.py (right):

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_brutality_test.py:4: # found in the LICENSE file.
On 2012/08/03 18:32:13, Nirnimesh wrote:
> Leave a blank line after this

Done.

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_brutality_test.py:7: 
On 2012/08/03 18:32:13, Nirnimesh wrote:
> need another blank line here

Done.

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_brutality_test.py:9: """This test class tests how
WebRTC deals with inconvenient reloads, etc."""
On 2012/08/03 18:32:13, Nirnimesh wrote:
> Remove "This test class"
> It's redundant

Done.

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_brutality_test.py:24: tab =
self.GetBrowserWindow(0).GetTab(0)
On 2012/08/03 18:32:13, Nirnimesh wrote:
> This format has been deprecated. Use the ReloadTab() call please.

Done.

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_brutality_test.py:53: tab.Reload()
On 2012/08/03 18:32:13, Nirnimesh wrote:
> ditto

Done.

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_brutality_test.py:60: tab =
self.GetBrowserWindow(0).GetTab(0)
I need to do this for Close() though, right?

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
File chrome/test/functional/webrtc_test_base.py (right):

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_test_base.py:13: """Acquires webcam or mic for one
tab and returns the result."""
On 2012/08/03 18:32:13, Nirnimesh wrote:
> Add Args  &  Returns: section. Describe what the result is

Done.

[Nirnimesh, 2012-08-06 20:52:11]

lgtm

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
File chrome/test/functional/webrtc_brutality_test.py (right):

http://codereview.chromium.org/10830159/diff/1/chrome/test/functional/webrtc_...
chrome/test/functional/webrtc_brutality_test.py:60: tab =
self.GetBrowserWindow(0).GetTab(0)
On 2012/08/06 15:02:18, phoglund wrote:
> I need to do this for Close() though, right?

For now, yes. Craig is in the middle of replacing it with CloseTab() which could
take indices.

[commit-bot: I haz the power, 2012-08-07 07:27:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phoglund@chromium.org/10830159/3002

[commit-bot: I haz the power, 2012-08-07 09:06:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phoglund@chromium.org/10830159/3002

[commit-bot: I haz the power, 2012-08-07 09:06:31]

Change committed as 150312