Skeleton code of SparseHistogram

base/metrics/histogram_base.h

Index: base/metrics/histogram_base.h
===================================================================
--- base/metrics/histogram_base.h	(revision 149721)
+++ base/metrics/histogram_base.h	(working copy)
@@ -9,6 +9,7 @@
 #include <string>
 
 #include "base/base_export.h"
+#include "base/basictypes.h"
 
 namespace base {
 
@@ -19,11 +20,32 @@
 
   static const Sample kSampleType_MAX;  // INT_MAX
 
+  enum Flags {
+    kNoFlags = 0,
+    kUmaTargetedHistogramFlag = 0x1,  // Histogram should be UMA uploaded.
+
+    // Indicate that the histogram was pickled to be sent across an IPC Channel.
+    // If we observe this flag on a histogram being aggregated into after IPC,
+    // then we are running in a single process mode, and the aggregation should
+    // not take place (as we would be aggregating back into the source
+    // histogram!).
+    kIPCSerializationSourceFlag = 0x10,
+
+    // Only for Histogram and its sub classes: fancy bucket-naming support.

[Ilya Sherman, 2012/08/04 01:18:35]

nit: It doesn't seem appropriate for HistogramBase to know about the Histogram
class.  I don't have any great design suggestions to improve this, though :(

[kaiwang, 2012/08/08 03:59:33]

agree... Let's keep this for code compatibility for now. Maybe we can improve
later

+    kHexRangePrintingFlag = 0x8000,
+  };
+
+
   HistogramBase(const std::string& name);
   virtual ~HistogramBase();
 
   std::string histogram_name() const { return histogram_name_; }
 
+  // Operations with Flags enum.
+  void SetFlags(int32 flags) { flags_ |= flags; }
+  void ClearFlags(int32 flags) { flags_ &= ~flags; }

[Ilya Sherman, 2012/08/04 01:18:35]

nit: Please either write the function names in hacker_case(), or move the
implementations to the implementation file (depending on whether it's important
for performance reasons for these functions to be inlined; I'm guessing it's
not...)

[kaiwang, 2012/08/08 03:59:33]

Will move to .cc file, so it will not affect other files calling these
functions.

+  int32 flags() const { return flags_; }
+
   virtual void Add(Sample value) = 0;
 
   // The following methods provide graphical histogram displays.
@@ -32,6 +54,7 @@
 
  private:
   const std::string histogram_name_;
+  int32 flags_;
 };
 
 }  // namespace base