Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6326)

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 10830144: Consolidate all NavigationController::LoadURL and family functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: tri-state ui override. address comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_navigator.cc
diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc
index dc1134cb5b657ea341b540aec1d29382bab8e844..92fddbc843cbb4fe1950a0cc0006ae42bdc1eb67 100644
--- a/chrome/browser/ui/browser_navigator.cc
+++ b/chrome/browser/ui/browser_navigator.cc
@@ -218,25 +218,19 @@ void LoadURLInContents(WebContents* target_contents,
const GURL& url,
chrome::NavigateParams* params,
const std::string& extra_headers) {
+ content::NavigationController::LoadURLParams load_url_params(url);
+ load_url_params.referrer = params->referrer;
+ load_url_params.transition_type = params->transition;
+ load_url_params.extra_headers = extra_headers;
+
if (params->transferred_global_request_id != GlobalRequestID()) {
- target_contents->GetController().TransferURL(
- url,
- params->referrer,
- params->transition, extra_headers,
- params->transferred_global_request_id,
- params->is_renderer_initiated);
+ load_url_params.is_renderer_initiated = params->is_renderer_initiated;
+ load_url_params.transferred_global_request_id =
+ params->transferred_global_request_id;
} else if (params->is_renderer_initiated) {
- target_contents->GetController().LoadURLFromRenderer(
- url,
- params->referrer,
- params->transition, extra_headers);
- } else {
- target_contents->GetController().LoadURL(
- url,
- params->referrer,
- params->transition, extra_headers);
+ load_url_params.is_renderer_initiated = true;
}
-
+ target_contents->GetController().LoadURLWithParams(load_url_params);
}
// This class makes sure the Browser object held in |params| is made visible

Powered by Google App Engine
This is Rietveld 408576698