Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2284)

Unified Diff: chrome/browser/instant/instant_loader.cc

Issue 10830144: Consolidate all NavigationController::LoadURL and family functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: tri-state ui override. address comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/instant/instant_loader.cc
diff --git a/chrome/browser/instant/instant_loader.cc b/chrome/browser/instant/instant_loader.cc
index 28dad8f8ddd82fd9bb6b52a1e07a65718b4fdc76..c94f60bf9a719e6a06d9110b9cbc6b72a81b5e80 100644
--- a/chrome/browser/instant/instant_loader.cc
+++ b/chrome/browser/instant/instant_loader.cc
@@ -756,9 +756,13 @@ bool InstantLoader::Update(TabContents* tab_contents,
preview_tab_contents_delegate_->PrepareForNewLoad();
frame_load_observer_.reset(NULL);
+ content::NavigationController::LoadURLParams load_url_params(url_);
+ load_url_params.transition_type = transition_type;
+ load_url_params.override_user_agent = override_user_agent ?
+ content::NavigationController::UA_OVERRIDE_TRUE :
+ content::NavigationController::UA_OVERRIDE_FALSE;
preview_contents_->web_contents()->GetController().
- LoadURLWithUserAgentOverride(url_, content::Referrer(), transition_type,
- false, std::string(), override_user_agent);
+ LoadURLWithParams(load_url_params);
}
return true;
}
@@ -1176,9 +1180,14 @@ void InstantLoader::LoadInstantURL(const TemplateURL* template_url,
if (cl->HasSwitch(switches::kInstantURL))
instant_url = GURL(cl->GetSwitchValueASCII(switches::kInstantURL));
+ content::NavigationController::LoadURLParams load_url_params(
+ instant_url);
+ load_url_params.transition_type = transition_type;
+ load_url_params.override_user_agent = override_user_agent ?
+ content::NavigationController::UA_OVERRIDE_TRUE :
+ content::NavigationController::UA_OVERRIDE_FALSE;
preview_contents_->web_contents()->GetController().
- LoadURLWithUserAgentOverride(instant_url, content::Referrer(),
- transition_type, false, std::string(), override_user_agent);
+ LoadURLWithParams(load_url_params);
RenderViewHost* host = preview_contents_->web_contents()->GetRenderViewHost();
preview_contents_->web_contents()->WasHidden();
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_contents.cc » ('j') | chrome/browser/prerender/prerender_contents.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698