chrome/common/extensions/extension_resource.h - Issue 10830123: crbug.com/124865 - DCHECK failure when pinning Chrome Web Store to Launcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_resource.h

Issue 10830123: crbug.com/124865 - DCHECK failure when pinning Chrome Web Store to Launcher (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: add check (!resource.empty()) to ImageLoadingTracker Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/ash/launcher/launcher_app_icon_loader.cc ('K') | « chrome/browser/ui/views/ash/launcher/launcher_app_icon_loader.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_resource.h

diff --git a/chrome/common/extensions/extension_resource.h b/chrome/common/extensions/extension_resource.h

index b1a3cdb51a5687c95d64e8094777bda9c9e1922b..36d8218c040a0de979ec4d4b4087aa2b69776942 100644

--- a/chrome/common/extensions/extension_resource.h

+++ b/chrome/common/extensions/extension_resource.h

@@ -57,7 +57,7 @@ class ExtensionResource {

const FilePath& extension_root() const { return extension_root_; }

const FilePath& relative_path() const { return relative_path_; }

- bool empty() { return extension_root().empty(); }

+ bool empty() const { return extension_root().empty(); }

// Unit test helpers.

FilePath::StringType NormalizeSeperators(

« chrome/browser/ui/views/ash/launcher/launcher_app_icon_loader.cc ('K') | « chrome/browser/ui/views/ash/launcher/launcher_app_icon_loader.cc ('k') | no next file » | no next file with comments »