Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: chrome/browser/ui/views/ash/launcher/launcher_app_icon_loader.cc

Issue 10830123: crbug.com/124865 - DCHECK failure when pinning Chrome Web Store to Launcher (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: restored an accidentally deleted newline Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/ash/launcher/launcher_app_icon_loader.cc
diff --git a/chrome/browser/ui/views/ash/launcher/launcher_app_icon_loader.cc b/chrome/browser/ui/views/ash/launcher/launcher_app_icon_loader.cc
index 4f6060d58c058e2f500dde72acca8e5201bb1354..5212c85c7d1e559ef9dc1c22884fe01053dbbca0 100644
--- a/chrome/browser/ui/views/ash/launcher/launcher_app_icon_loader.cc
+++ b/chrome/browser/ui/views/ash/launcher/launcher_app_icon_loader.cc
@@ -45,13 +45,16 @@ void LauncherAppIconLoader::FetchImage(const std::string& id) {
if (!image_loader_.get())
image_loader_.reset(new ImageLoadingTracker(this));
map_[image_loader_->next_id()] = id;
+ ExtensionResource extensionResource =
Aaron Boodman 2012/08/06 03:09:34 extension_resource
sschmitz 2012/08/07 17:59:00 Done.
+ extension->GetIconResource(ExtensionIconSet::EXTENSION_ICON_SMALL,
+ ExtensionIconSet::MATCH_BIGGER);
image_loader_->LoadImage(
extension,
- extension->GetIconResource(ExtensionIconSet::EXTENSION_ICON_SMALL,
- ExtensionIconSet::MATCH_BIGGER),
+ extensionResource,
gfx::Size(ExtensionIconSet::EXTENSION_ICON_SMALL,
ExtensionIconSet::EXTENSION_ICON_SMALL),
- ImageLoadingTracker::CACHE);
+ extensionResource.empty() ? ImageLoadingTracker::DONT_CACHE :
+ ImageLoadingTracker::CACHE);
}
void LauncherAppIconLoader::OnImageLoaded(const gfx::Image& image,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698