Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: chrome/browser/extensions/image_loading_tracker.cc

Issue 10830123: crbug.com/124865 - DCHECK failure when pinning Chrome Web Store to Launcher (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: revert file to master version: launcher_app_icon_loader.cc Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/extension_resource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/image_loading_tracker.cc
diff --git a/chrome/browser/extensions/image_loading_tracker.cc b/chrome/browser/extensions/image_loading_tracker.cc
index ea84c34fe5dc55d490b8af4ea2a5971c38ecc3e1..02fd19bce02b7f5af03ea567368a1296649b24ed 100644
--- a/chrome/browser/extensions/image_loading_tracker.cc
+++ b/chrome/browser/extensions/image_loading_tracker.cc
@@ -311,7 +311,7 @@ void ImageLoadingTracker::OnImageLoaded(
// Add to the extension's image cache if requested.
DCHECK(info->cache != CACHE || info->extension);
- if (should_cache && info->cache == CACHE &&
+ if (should_cache && info->cache == CACHE && !resource.empty() &&
!info->extension->HasCachedImage(resource, original_size)) {
info->extension->SetCachedImage(resource, image ? *image : SkBitmap(),
original_size);
« no previous file with comments | « no previous file | chrome/common/extensions/extension_resource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698