Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 10830114: Show the IME notification if the system shelf is hidden (Closed)

Created:
8 years, 4 months ago by Zachary Kuznia
Modified:
8 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Show the IME notification if the system shelf is hidden BUG=120576 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149578

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reuse the same notification #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M ash/system/ime/tray_ime.cc View 1 4 chunks +26 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Zachary Kuznia
Hello sadrul, Please review this at: https://chromiumcodereview.appspot.com/10830114 Thanks, -Zach
8 years, 4 months ago (2012-08-01 09:24:59 UTC) #1
sadrul
http://codereview.chromium.org/10830114/diff/1/ash/system/ime/tray_ime.cc File ash/system/ime/tray_ime.cc (right): http://codereview.chromium.org/10830114/diff/1/ash/system/ime/tray_ime.cc#newcode327 ash/system/ime/tray_ime.cc:327: HideNotificationView(); Can we update the existing notification instead of ...
8 years, 4 months ago (2012-08-01 15:00:41 UTC) #2
Zachary Kuznia
http://codereview.chromium.org/10830114/diff/1/ash/system/ime/tray_ime.cc File ash/system/ime/tray_ime.cc (right): http://codereview.chromium.org/10830114/diff/1/ash/system/ime/tray_ime.cc#newcode327 ash/system/ime/tray_ime.cc:327: HideNotificationView(); On 2012/08/01 15:00:41, sadrul wrote: > Can we ...
8 years, 4 months ago (2012-08-02 01:51:18 UTC) #3
sadrul
LGTM
8 years, 4 months ago (2012-08-02 02:52:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/10830114/3002
8 years, 4 months ago (2012-08-02 03:07:28 UTC) #5
commit-bot: I haz the power
Try job failure for 10830114-3002 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-02 03:23:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/10830114/3002
8 years, 4 months ago (2012-08-02 03:34:29 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 05:27:06 UTC) #8
Change committed as 149578

Powered by Google App Engine
This is Rietveld 408576698