[cros] Encode user images when set from WebUI (regression fix).

chrome/browser/chromeos/login/user_image.h

Index: chrome/browser/chromeos/login/user_image.h
diff --git a/chrome/browser/chromeos/login/user_image.h b/chrome/browser/chromeos/login/user_image.h
index 0afb26649330be96cc24b67cc66df17aeb05f691..b2a52f9f9cf7e9e76ef62f716354903f4748fec8 100644
--- a/chrome/browser/chromeos/login/user_image.h
+++ b/chrome/browser/chromeos/login/user_image.h
@@ -20,6 +20,10 @@ class UserImage {
   // TODO(ivankr): replace with RefCountedMemory to prevent copying.
   typedef std::vector<unsigned char> RawImage;
 
+  // Creates a new instance from a given still frame and tries to encode raw
+  // representation for it.
+  static UserImage CreateAndEncode(const gfx::ImageSkia& image);

[darin (slow to review), 2012/08/02 22:15:30]

maybe it would be helpful to invent factory style methods and make the
constructors private?  it is confusing to have two different ways of
constructing a class.

one downside of doing that however is that the copy-by-value is expensive.  you
could use RefCountedMemory as you say above or you could just wrap the entire
guts on this class with a RefCounted inner class.

or you could always heap allocate the class and return scoped_ptr<UserImage>.

+
   // Create instance with an empty still frame and no raw data.
   UserImage();
 
@@ -40,6 +44,9 @@ class UserImage {
   bool has_raw_image() const { return has_raw_image_; }
   const RawImage& raw_image() const { return raw_image_; }
 
+  // Discards the stored raw image, freeing used memory.
+  void DiscardRawImage();
+
   // Optional raw representation of the animated image.
   bool has_animated_image() const { return has_animated_image_; }
   const RawImage& animated_image() const { return animated_image_; }