Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Unified Diff: media/base/video_decoder_config.h

Issue 10830110: Remove VideoDecoderConfig::aspect_ratio_xxx methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/video_decoder_config.cc » ('j') | media/base/video_decoder_config.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_decoder_config.h
diff --git a/media/base/video_decoder_config.h b/media/base/video_decoder_config.h
index 9f5785c3ad44b463917f2e1f2a9390675cf68d82..f534cc2241949012473185ee9d5d3a74c3bf1043 100644
--- a/media/base/video_decoder_config.h
+++ b/media/base/video_decoder_config.h
@@ -72,7 +72,6 @@ class MEDIA_EXPORT VideoDecoderConfig {
VideoFrame::Format format,
const gfx::Size& coded_size,
const gfx::Rect& visible_rect,
- int aspect_ratio_numerator, int aspect_ratio_denominator,
const uint8* extra_data, size_t extra_data_size);
~VideoDecoderConfig();
@@ -83,7 +82,7 @@ class MEDIA_EXPORT VideoDecoderConfig {
VideoFrame::Format format,
const gfx::Size& coded_size,
const gfx::Rect& visible_rect,
- int aspect_ratio_numerator, int aspect_ratio_denominator,
+ const gfx::Size& natural_size,
const uint8* extra_data, size_t extra_data_size,
bool record_stats);
@@ -119,13 +118,6 @@ class MEDIA_EXPORT VideoDecoderConfig {
// into account.
gfx::Size natural_size() const;
- // Aspect ratio of the decoded video frame expressed as a fraction.
- //
- // TODO(scherkus): think of a better way to avoid having video decoders
- // handle tricky aspect ratio dimension calculations.
- int aspect_ratio_numerator() const;
- int aspect_ratio_denominator() const;
-
// Optional byte data required to initialize video decoders, such as H.264
// AAVC data.
uint8* extra_data() const;
@@ -141,9 +133,6 @@ class MEDIA_EXPORT VideoDecoderConfig {
gfx::Rect visible_rect_;
gfx::Size natural_size_;
- int aspect_ratio_numerator_;
- int aspect_ratio_denominator_;
-
scoped_array<uint8> extra_data_;
size_t extra_data_size_;
« no previous file with comments | « no previous file | media/base/video_decoder_config.cc » ('j') | media/base/video_decoder_config.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698