media/filters/ffmpeg_demuxer_unittest.cc - Issue 10830110: Remove VideoDecoderConfig::aspect_ratio_xxx methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/ffmpeg_demuxer_unittest.cc

Issue 10830110: Remove VideoDecoderConfig::aspect_ratio_xxx methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address CR comments & added tests Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/ffmpeg_demuxer_unittest.cc

diff --git a/media/filters/ffmpeg_demuxer_unittest.cc b/media/filters/ffmpeg_demuxer_unittest.cc

index da1e3a60e1f6f98a0e929dd92fbfaa313b564d78..7c3d37cfecc4d05fa2065e8d31f416a12ee3a7e9 100644

--- a/media/filters/ffmpeg_demuxer_unittest.cc

+++ b/media/filters/ffmpeg_demuxer_unittest.cc

@@ -242,8 +242,8 @@ TEST_F(FFmpegDemuxerTest, Initialize_Successful) {

EXPECT_EQ(0, video_config.visible_rect().y());

EXPECT_EQ(320, video_config.visible_rect().width());

EXPECT_EQ(240, video_config.visible_rect().height());

- EXPECT_EQ(1, video_config.aspect_ratio_numerator());

- EXPECT_EQ(1, video_config.aspect_ratio_denominator());

+ EXPECT_EQ(320, video_config.natural_size().width());

+ EXPECT_EQ(240, video_config.natural_size().height());

EXPECT_FALSE(video_config.extra_data());

EXPECT_EQ(0u, video_config.extra_data_size());