Remove VideoDecoderConfig::aspect_ratio_xxx methods.

media/base/video_decoder_config.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_VIDEO_DECODER_CONFIG_H_
 #define MEDIA_BASE_VIDEO_DECODER_CONFIG_H_
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "media/base/media_export.h"
@@ skipping 47 matching lines @@
   VP8PROFILE_MAX = VP8PROFILE_MAIN,
   VIDEO_CODEC_PROFILE_MAX = VP8PROFILE_MAX,
 };
 
 class MEDIA_EXPORT VideoDecoderConfig {
  public:
   // Constructs an uninitialized object. Clients should call Initialize() with
   // appropriate values before using.
   VideoDecoderConfig();
 
   // Constructs an initialized object. It is acceptable to pass in NULL for

[Ami GONE FROM CHROMIUM, 2012/08/01 17:45:23]

Is there a reason this form doesn't accept a natural_size?
At least comment about it?

[acolwell GONE FROM CHROMIUM, 2012/08/01 20:52:40]

It was only used by tests that didn't have aspect ratios other than 1/1. I'll
just update the tests since this isn't a good reason. :)

   // |extra_data|, otherwise the memory is copied.
   VideoDecoderConfig(VideoCodec codec,
                      VideoCodecProfile profile,
                      VideoFrame::Format format,
                      const gfx::Size& coded_size,
                      const gfx::Rect& visible_rect,
-                     int aspect_ratio_numerator, int aspect_ratio_denominator,
                      const uint8* extra_data, size_t extra_data_size);
 
   ~VideoDecoderConfig();
 
   // Resets the internal state of this object.
   void Initialize(VideoCodec codec,
                   VideoCodecProfile profile,
                   VideoFrame::Format format,
                   const gfx::Size& coded_size,
                   const gfx::Rect& visible_rect,
-                  int aspect_ratio_numerator, int aspect_ratio_denominator,
+                  const gfx::Size& natural_size,
                   const uint8* extra_data, size_t extra_data_size,
                   bool record_stats);
 
   // Deep copies |video_config|.
   void CopyFrom(const VideoDecoderConfig& video_config);
 
   // Returns true if this object has appropriate configuration values, false
   // otherwise.
   bool IsValidConfig() const;
 
@@ skipping 15 matching lines @@
   // in this region are valid.
   gfx::Size coded_size() const;
 
   // Region of |coded_size_| that is visible.
   gfx::Rect visible_rect() const;
 
   // Final visible width and height of a video frame with aspect ratio taken
   // into account.
   gfx::Size natural_size() const;
 
-  // Aspect ratio of the decoded video frame expressed as a fraction.
-  //
-  // TODO(scherkus): think of a better way to avoid having video decoders
-  // handle tricky aspect ratio dimension calculations.
-  int aspect_ratio_numerator() const;
-  int aspect_ratio_denominator() const;
-
   // Optional byte data required to initialize video decoders, such as H.264
   // AAVC data.
   uint8* extra_data() const;
   size_t extra_data_size() const;
 
  private:
   VideoCodec codec_;
   VideoCodecProfile profile_;
 
   VideoFrame::Format format_;
 
   gfx::Size coded_size_;
   gfx::Rect visible_rect_;
   gfx::Size natural_size_;
 
-  int aspect_ratio_numerator_;
-  int aspect_ratio_denominator_;
-
   scoped_array<uint8> extra_data_;
   size_t extra_data_size_;
 
   DISALLOW_COPY_AND_ASSIGN(VideoDecoderConfig);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_VIDEO_DECODER_CONFIG_H_