Issue 10830110: Remove VideoDecoderConfig::aspect_ratio_xxx methods.

Issue 10830110: Remove VideoDecoderConfig::aspect_ratio_xxx methods. (Closed)

Created:
8 years, 4 months ago by acolwell GONE FROM CHROMIUM

Modified:
8 years, 4 months ago

Reviewers:
Ami GONE FROM CHROMIUM

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove VideoDecoderConfig::aspect_ratio_xxx methods. BUG=122913 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149540

Patch Set 2 : Address CR comments & added tests #

Total comments: 4

Patch Set 3 : Addressed comments & rebased #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+121 lines, -74 lines)			Patch
M	media/base/video_decoder_config.h	View	1	4 chunks	+2 lines, -12 lines	0 comments	Download
M	media/base/video_decoder_config.cc	View	1	10 chunks	+8 lines, -43 lines	0 comments	Download
M	media/base/video_util.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	media/base/video_util.cc	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	media/ffmpeg/ffmpeg_common.cc	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	media/filters/ffmpeg_demuxer_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/filters/ffmpeg_video_decoder_unittest.cc	View	1 2	6 chunks	+63 lines, -9 lines	0 comments	Download
M	media/filters/pipeline_integration_test.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	media/mp4/mp4_stream_parser.cc	View	1 2	2 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

http://codereview.chromium.org/10830110/diff/5003/media/mp4/mp4_stream_parser.cc File media/mp4/mp4_stream_parser.cc (right): http://codereview.chromium.org/10830110/diff/5003/media/mp4/mp4_stream_parser.cc#newcode232 media/mp4/mp4_stream_parser.cc:232: NULL, 0, true); This being false was a bug.

8 years, 4 months ago (2012-08-01 17:29:23 UTC) #1

Ami GONE FROM CHROMIUM

You know what would be nice? Tests would be nice... http://codereview.chromium.org/10830110/diff/5003/media/base/video_decoder_config.cc File media/base/video_decoder_config.cc (right): http://codereview.chromium.org/10830110/diff/5003/media/base/video_decoder_config.cc#newcode27 ...

8 years, 4 months ago (2012-08-01 17:45:23 UTC) #2

acolwell GONE FROM CHROMIUM

PTAL. Tests added. http://codereview.chromium.org/10830110/diff/5003/media/base/video_decoder_config.cc File media/base/video_decoder_config.cc (right): http://codereview.chromium.org/10830110/diff/5003/media/base/video_decoder_config.cc#newcode27 media/base/video_decoder_config.cc:27: gfx::Size(visible_rect.width(), visible_rect.height()), On 2012/08/01 17:45:23, Ami ...

8 years, 4 months ago (2012-08-01 20:52:40 UTC) #3

Ami GONE FROM CHROMIUM

LGTM http://codereview.chromium.org/10830110/diff/2003/media/filters/ffmpeg_video_decoder_unittest.cc File media/filters/ffmpeg_video_decoder_unittest.cc (right): http://codereview.chromium.org/10830110/diff/2003/media/filters/ffmpeg_video_decoder_unittest.cc#newcode273 media/filters/ffmpeg_video_decoder_unittest.cc:273: gfx::Size natural_size = GetNaturalSize(kVisibleRect.size(), 1, 0); s/1, 0/0, ...

8 years, 4 months ago (2012-08-01 21:05:13 UTC) #4

acolwell GONE FROM CHROMIUM

8 years, 4 months ago (2012-08-01 23:20:45 UTC) #5

https://chromiumcodereview.appspot.com/10830110/diff/2003/media/filters/ffmpe...
File media/filters/ffmpeg_video_decoder_unittest.cc (right):

https://chromiumcodereview.appspot.com/10830110/diff/2003/media/filters/ffmpe...
media/filters/ffmpeg_video_decoder_unittest.cc:273: gfx::Size natural_size =
GetNaturalSize(kVisibleRect.size(), 1, 0);
On 2012/08/01 21:05:13, Ami Fischman wrote:
> s/1, 0/0, 1/

Done.

https://chromiumcodereview.appspot.com/10830110/diff/2003/media/filters/pipel...
File media/filters/pipeline_integration_test.cc (right):

https://chromiumcodereview.appspot.com/10830110/diff/2003/media/filters/pipel...
media/filters/pipeline_integration_test.cc:287:
ASSERT_TRUE(Start(GetTestDataURL("bear-320x240-16x9-aspect.webm"),
On 2012/08/01 21:05:13, Ami Fischman wrote:
> Did you forget to add this file to the CL?
No. Since I have to land it separately I just left it out. Less git pain for me
that way. FTR here is the test file CL http://codereview.chromium.org/10823128/

Expand Messages | Collapse Messages