[Web Intents] Add ability to dispatch intents from extension-caused code (i.e. context menus)

chrome/browser/extensions/extension_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_host.h"
 
 #include <list>
 
 #include "base/bind.h"
 #include "base/memory/singleton.h"
@@ skipping 27 matching lines @@
 #include "chrome/common/render_messages.h"
 #include "chrome/common/url_constants.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
+#include "content/public/browser/web_intents_dispatcher.h"
 #include "grit/browser_resources.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "ui/base/keycodes/keyboard_codes.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/layout.h"
 #include "ui/base/resource/resource_bundle.h"
 
 using WebKit::WebDragOperation;
 using WebKit::WebDragOperationsMask;
@@ skipping 353 matching lines @@
 void ExtensionHost::OnStartDownload(
     content::WebContents* source, content::DownloadItem* download) {
   // If |source| is in the context of a Browser, show the DownloadShelf on that
   // Browser.
   if (!view() || !view()->browser())
     return;
   static_cast<content::WebContentsDelegate*>(view()->browser())->
     OnStartDownload(source, download);
 }
 
+void ExtensionHost::WebIntentDispatch(

[groby-ooo-7-16, 2012/07/31 19:26:17]

This seems to have odd ownership rules for intents_dispatcher. Always takes
ownership? (In which case, should it be a scoped_ptr?)

[Greg Billock, 2012/08/01 17:02:26]

Yes, callee takes ownership. This is documented in the WebIntentsDispatcher and
WebContentsDelegate API.

[groby-ooo-7-16, 2012/08/01 18:17:06]

In this case, please use scoped_ptr. (And .release() in the call to
WebIntentDispatch)
On 2012/08/01 17:02:26, Greg Billock wrote:

[Greg Billock, 2012/08/07 00:23:57]

Done.

+    content::WebContents* web_contents,
+    content::WebIntentsDispatcher* intents_dispatcher) {
+
+  Browser* browser = view() ? view()->browser()
+                            : browser::FindBrowserWithWebContents(web_contents);
+
+  // For background scripts/pages, there will be no view(). In this case, we
+  // want to treat the intent as a browser-initiated one and deliver it into the
+  // current browser. It probably came from a context menu click or similar.
+  if (!browser)
+    browser = web_intents::GetWebIntentDeliveryBrowser(profile());
+
+  if (browser) {
+    static_cast<WebContentsDelegate*>(browser)->
+        WebIntentDispatch(NULL, intents_dispatcher);
+    return;
+  }
+
+  delete intents_dispatcher;
+}
+
 void ExtensionHost::WillRunJavaScriptDialog() {
   ExtensionProcessManager* pm =
       ExtensionSystem::Get(profile_)->process_manager();
   if (pm)
     pm->IncrementLazyKeepaliveCount(extension());
 }
 
 void ExtensionHost::DidCloseJavaScriptDialog() {
   ExtensionProcessManager* pm =
       ExtensionSystem::Get(profile_)->process_manager();
@@ skipping 161 matching lines @@
   ExtensionTabUtil::CreateTab(new_contents, extension_id_, disposition,
                               initial_pos, user_gesture);
 }
 
 void ExtensionHost::RenderViewReady() {
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_HOST_CREATED,
       content::Source<Profile>(profile_),
       content::Details<ExtensionHost>(this));
 }