content/renderer/pepper/pepper_device_enumeration_event_handler.cc - Issue 10830063: refactor EnumerateDevices to make it a persistent request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_device_enumeration_event_handler.cc

Issue 10830063: refactor EnumerateDevices to make it a persistent request. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix unit test Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/pepper_device_enumeration_event_handler.cc

===================================================================

--- content/renderer/pepper/pepper_device_enumeration_event_handler.cc (revision 150440)

+++ content/renderer/pepper/pepper_device_enumeration_event_handler.cc (working copy)

@@ -127,7 +127,8 @@

const media_stream::StreamDeviceInfoArray& device_array) {

EnumerateCallbackMap::iterator iter = enumerate_callbacks_.find(request_id);

if (iter == enumerate_callbacks_.end()) {

- NOTREACHED();

+ // This might be enumerated result sent before StopEnumerateDevices is

+ // called since EnumerateDevices is persistent request.

return;

}