Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chromeos/dbus/cryptohome_client.h

Issue 10830033: Convert chromeos::CryptohomeClient::TpmCanAttemptOwnership to asynchronous (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comment Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/cros/cryptohome_library.cc ('k') | chromeos/dbus/cryptohome_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/cryptohome_client.h
diff --git a/chromeos/dbus/cryptohome_client.h b/chromeos/dbus/cryptohome_client.h
index 530f57fe94b3783a6602831bfbb2a1f7595d0738..f4a86837ca1a99a62d88cf884a0190047d369fb6 100644
--- a/chromeos/dbus/cryptohome_client.h
+++ b/chromeos/dbus/cryptohome_client.h
@@ -30,6 +30,9 @@ class CHROMEOS_EXPORT CryptohomeClient {
> AsyncCallStatusHandler;
// A callback to handle responses of AsyncXXX methods.
typedef base::Callback<void(int async_id)> AsyncMethodCallback;
+ // A callback to handle responses of methods without result values.
+ typedef base::Callback<void(
+ DBusMethodCallStatus call_status)> VoidMethodCallback;
// A callback to handle responses of methods returning a bool value.
typedef base::Callback<void(DBusMethodCallStatus call_status,
bool result)> BoolMethodCallback;
@@ -121,9 +124,9 @@ class CHROMEOS_EXPORT CryptohomeClient {
// This method blocks until the call returns.
virtual bool TpmIsBeingOwned(bool* owning) = 0;
- // Calls TpmCanAttemptOwnership method and returns true when the call
- // succeeds. This method blocks until the call returns.
- virtual bool TpmCanAttemptOwnership() = 0;
+ // Calls TpmCanAttemptOwnership method.
+ // This method tells the service that it is OK to attempt ownership.
+ virtual void TpmCanAttemptOwnership(const VoidMethodCallback& callback) = 0;
// Calls TpmClearStoredPassword method and returns true when the call
// succeeds. This method blocks until the call returns.
« no previous file with comments | « chrome/browser/chromeos/cros/cryptohome_library.cc ('k') | chromeos/dbus/cryptohome_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698