Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Unified Diff: chrome/browser/chromeos/cros/cryptohome_library.cc

Issue 10830033: Convert chromeos::CryptohomeClient::TpmCanAttemptOwnership to asynchronous (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/dbus/cryptohome_client.h » ('j') | chromeos/dbus/cryptohome_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/cryptohome_library.cc
diff --git a/chrome/browser/chromeos/cros/cryptohome_library.cc b/chrome/browser/chromeos/cros/cryptohome_library.cc
index 176eaef26f0c5d97f4d95d646358947746f87dba..d470eec61c6c648705c4f60c21a8df0f76199b7f 100644
--- a/chrome/browser/chromeos/cros/cryptohome_library.cc
+++ b/chrome/browser/chromeos/cros/cryptohome_library.cc
@@ -6,19 +6,23 @@
#include <map>
+#include "base/bind.h"
#include "base/memory/weak_ptr.h"
#include "base/string_number_conversions.h"
#include "base/string_util.h"
#include "chromeos/dbus/cryptohome_client.h"
#include "chromeos/dbus/dbus_thread_manager.h"
+namespace chromeos {
+
namespace {
const char kStubSystemSalt[] = "stub_system_salt";
-}
+// Does nothing. Used as a Cryptohome::VoidMethodCallback.
+void DoNothing(DBusMethodCallStatus call_status) {}
stevenjb 2012/07/26 17:19:52 Should we consider adding this where DBusMethodCal
hashimoto 2012/07/27 04:37:18 We're having the exactly same function in cros_net
stevenjb 2012/07/30 22:24:38 Sounds good.
-namespace chromeos {
+} // namespace
// This class handles the interaction with the ChromeOS cryptohome library APIs.
class CryptohomeLibraryImpl : public CryptohomeLibrary {
@@ -55,7 +59,8 @@ class CryptohomeLibraryImpl : public CryptohomeLibrary {
}
virtual void TpmCanAttemptOwnership() OVERRIDE {
- DBusThreadManager::Get()->GetCryptohomeClient()->TpmCanAttemptOwnership();
+ DBusThreadManager::Get()->GetCryptohomeClient()->TpmCanAttemptOwnership(
+ base::Bind(&DoNothing));
}
virtual void TpmClearStoredPassword() OVERRIDE {
« no previous file with comments | « no previous file | chromeos/dbus/cryptohome_client.h » ('j') | chromeos/dbus/cryptohome_client.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698