Issue 10830017: Don't use MessageLoop and MessageLoopProxy in remoting/jingle_glue

Issue 10830017: Don't use MessageLoop and MessageLoopProxy in remoting/jingle_glue (Closed)

Created:
8 years, 5 months ago by Sergey Ulanov

Modified:
8 years, 4 months ago

Reviewers:
alexeypa (please no reviews)

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't use MessageLoop and MessageLoopProxy in remoting/jingle_glue MessageLoopProxy::current() may not work properly on plugin threads unless the plugin is compiled into the browser. BUG=134216 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148811

Patch Set 1 : #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	remoting/jingle_glue/fake_signal_strategy.cc	View		2 chunks	+4 lines, -2 lines	2 comments	Download
	M	remoting/jingle_glue/iq_sender.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

alexeypa (please no reviews)

lgtm http://codereview.chromium.org/10830017/diff/3001/remoting/jingle_glue/fake_signal_strategy.cc File remoting/jingle_glue/fake_signal_strategy.cc (right): http://codereview.chromium.org/10830017/diff/3001/remoting/jingle_glue/fake_signal_strategy.cc#newcode8 remoting/jingle_glue/fake_signal_strategy.cc:8: #include "base/location.h" nit: Does base/location.h is really needed ...

8 years, 4 months ago (2012-07-27 15:43:49 UTC) #3

Sergey Ulanov

http://codereview.chromium.org/10830017/diff/3001/remoting/jingle_glue/fake_signal_strategy.cc File remoting/jingle_glue/fake_signal_strategy.cc (right): http://codereview.chromium.org/10830017/diff/3001/remoting/jingle_glue/fake_signal_strategy.cc#newcode8 remoting/jingle_glue/fake_signal_strategy.cc:8: #include "base/location.h" On 2012/07/27 15:43:50, alexeypa wrote: > nit: ...

8 years, 4 months ago (2012-07-27 18:49:48 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10830017/3001

8 years, 4 months ago (2012-07-27 18:50:19 UTC) #5

Change committed as 148811

Expand Messages | Collapse Messages