Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: remoting/base/plugin_thread_task_runner.cc

Issue 10830016: Replace PluginMessageLoopProxy with PluginThreadTaskRunner. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « remoting/base/plugin_thread_task_runner.h ('k') | remoting/client/plugin/chromoting_instance.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/base/plugin_message_loop_proxy.h" 5 #include "remoting/base/plugin_thread_task_runner.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 8
9 namespace remoting { 9 namespace remoting {
10 10
11 PluginMessageLoopProxy::PluginMessageLoopProxy(Delegate* delegate) 11 PluginThreadTaskRunner::PluginThreadTaskRunner(Delegate* delegate)
12 : plugin_thread_id_(base::PlatformThread::CurrentId()), 12 : plugin_thread_id_(base::PlatformThread::CurrentId()),
13 delegate_(delegate) { 13 delegate_(delegate) {
14 } 14 }
15 15
16 PluginMessageLoopProxy::~PluginMessageLoopProxy() { 16 PluginThreadTaskRunner::~PluginThreadTaskRunner() {
17 } 17 }
18 18
19 void PluginMessageLoopProxy::Detach() { 19 void PluginThreadTaskRunner::Detach() {
20 base::AutoLock auto_lock(lock_); 20 base::AutoLock auto_lock(lock_);
21 if (delegate_) { 21 if (delegate_) {
22 DCHECK(BelongsToCurrentThread()); 22 DCHECK(BelongsToCurrentThread());
23 delegate_ = NULL; 23 delegate_ = NULL;
24 } 24 }
25 } 25 }
26 26
27 bool PluginMessageLoopProxy::PostDelayedTask( 27 bool PluginThreadTaskRunner::PostDelayedTask(
28 const tracked_objects::Location& from_here, 28 const tracked_objects::Location& from_here,
29 const base::Closure& task, 29 const base::Closure& task,
30 base::TimeDelta delay) { 30 base::TimeDelta delay) {
31 base::AutoLock auto_lock(lock_); 31 base::AutoLock auto_lock(lock_);
32 if (!delegate_) 32 if (!delegate_)
33 return false; 33 return false;
34 34
35 base::Closure* springpad_closure = new base::Closure(base::Bind( 35 base::Closure* springpad_closure = new base::Closure(base::Bind(
36 &PluginMessageLoopProxy::RunClosureIf, this, task)); 36 &PluginThreadTaskRunner::RunClosureIf, this, task));
37 return delegate_->RunOnPluginThread( 37 return delegate_->RunOnPluginThread(
38 delay, &PluginMessageLoopProxy::TaskSpringboard, springpad_closure); 38 delay, &PluginThreadTaskRunner::TaskSpringboard, springpad_closure);
39 } 39 }
40 40
41 bool PluginMessageLoopProxy::PostNonNestableDelayedTask( 41 bool PluginThreadTaskRunner::PostNonNestableDelayedTask(
42 const tracked_objects::Location& from_here, 42 const tracked_objects::Location& from_here,
43 const base::Closure& task, 43 const base::Closure& task,
44 base::TimeDelta delay) { 44 base::TimeDelta delay) {
45 // All tasks running on this message loop are non-nestable. 45 // All tasks running on this message loop are non-nestable.
46 return PostDelayedTask(from_here, task, delay); 46 return PostDelayedTask(from_here, task, delay);
47 } 47 }
48 48
49 bool PluginMessageLoopProxy::RunsTasksOnCurrentThread() const { 49 bool PluginThreadTaskRunner::RunsTasksOnCurrentThread() const {
50 // In pepper plugins ideally we should use pp::Core::IsMainThread, 50 // In pepper plugins ideally we should use pp::Core::IsMainThread,
51 // but it is problematic because we would need to keep reference to 51 // but it is problematic because we would need to keep reference to
52 // Core somewhere, e.g. make the delegate ref-counted. 52 // Core somewhere, e.g. make the delegate ref-counted.
53 return base::PlatformThread::CurrentId() == plugin_thread_id_; 53 return base::PlatformThread::CurrentId() == plugin_thread_id_;
54 } 54 }
55 55
56 // static 56 // static
57 void PluginMessageLoopProxy::TaskSpringboard(void* data) { 57 void PluginThreadTaskRunner::TaskSpringboard(void* data) {
58 base::Closure* task = reinterpret_cast<base::Closure*>(data); 58 base::Closure* task = reinterpret_cast<base::Closure*>(data);
59 task->Run(); 59 task->Run();
60 delete task; 60 delete task;
61 } 61 }
62 62
63 void PluginMessageLoopProxy::RunClosureIf(const base::Closure& task) { 63 void PluginThreadTaskRunner::RunClosureIf(const base::Closure& task) {
64 // |delegate_| can be changed only from our thread, so it's safe to 64 // |delegate_| can be changed only from our thread, so it's safe to
65 // access it without acquiring |lock_|. 65 // access it without acquiring |lock_|.
66 if (delegate_) 66 if (delegate_)
67 task.Run(); 67 task.Run();
68 } 68 }
69 69
70 } // namespace remoting 70 } // namespace remoting
OLDNEW
« no previous file with comments | « remoting/base/plugin_thread_task_runner.h ('k') | remoting/client/plugin/chromoting_instance.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698