Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: remoting/base/plugin_thread_task_runner.h

Issue 10830016: Replace PluginMessageLoopProxy with PluginThreadTaskRunner. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « remoting/base/plugin_message_loop_proxy.cc ('k') | remoting/base/plugin_thread_task_runner.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_BASE_PLUGIN_MESSAGE_LOOP_H_ 5 #ifndef REMOTING_BASE_PLUGIN_THREAD_TASK_RUNNER_H_
6 #define REMOTING_BASE_PLUGIN_MESSAGE_LOOP_H_ 6 #define REMOTING_BASE_PLUGIN_THREAD_TASK_RUNNER_H_
7 7
8 #include "base/callback_forward.h" 8 #include "base/callback_forward.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/message_loop_proxy.h" 10 #include "base/single_thread_task_runner.h"
11 #include "base/synchronization/lock.h" 11 #include "base/synchronization/lock.h"
12 #include "base/threading/platform_thread.h" 12 #include "base/threading/platform_thread.h"
13 13
14 namespace remoting { 14 namespace remoting {
15 15
16 // MessageLoopProxy for plugin main threads. 16 // SingleThreadTaskRunner for plugin main threads.
17 class PluginMessageLoopProxy : public base::MessageLoopProxy { 17 class PluginThreadTaskRunner : public base::SingleThreadTaskRunner {
18 public: 18 public:
19 class Delegate { 19 class Delegate {
20 public: 20 public:
21 Delegate() { } 21 Delegate() { }
22 virtual ~Delegate() { } 22 virtual ~Delegate() { }
23 23
24 virtual bool RunOnPluginThread( 24 virtual bool RunOnPluginThread(
25 base::TimeDelta delay, void(function)(void*), void* data) = 0; 25 base::TimeDelta delay, void(function)(void*), void* data) = 0;
26 }; 26 };
27 27
28 // Caller keeps ownership of delegate. 28 // Caller keeps ownership of delegate.
29 PluginMessageLoopProxy(Delegate* delegate); 29 PluginThreadTaskRunner(Delegate* delegate);
30 30
31 void Detach(); 31 void Detach();
32 32
33 // base::MessageLoopProxy implementation. 33 // base::MessageLoopProxy implementation.
alexeypa (please no reviews) 2012/07/27 15:40:04 nit: base::SingleThreadTaskRunner implementation.
Sergey Ulanov 2012/07/27 18:55:47 Done.
34 virtual bool PostDelayedTask( 34 virtual bool PostDelayedTask(
35 const tracked_objects::Location& from_here, 35 const tracked_objects::Location& from_here,
36 const base::Closure& task, 36 const base::Closure& task,
37 base::TimeDelta delay) OVERRIDE; 37 base::TimeDelta delay) OVERRIDE;
38 virtual bool PostNonNestableDelayedTask( 38 virtual bool PostNonNestableDelayedTask(
39 const tracked_objects::Location& from_here, 39 const tracked_objects::Location& from_here,
40 const base::Closure& task, 40 const base::Closure& task,
41 base::TimeDelta delay) OVERRIDE; 41 base::TimeDelta delay) OVERRIDE;
42 42
43 virtual bool RunsTasksOnCurrentThread() const OVERRIDE; 43 virtual bool RunsTasksOnCurrentThread() const OVERRIDE;
44 44
45 protected: 45 protected:
46 virtual ~PluginMessageLoopProxy(); 46 virtual ~PluginThreadTaskRunner();
47 47
48 private: 48 private:
49 static void TaskSpringboard(void* data); 49 static void TaskSpringboard(void* data);
50 50
51 void RunClosureIf(const base::Closure& task); 51 void RunClosureIf(const base::Closure& task);
52 52
53 base::PlatformThreadId plugin_thread_id_; 53 base::PlatformThreadId plugin_thread_id_;
54 54
55 // |lock_| must be acquired when accessing |delegate_|. 55 // |lock_| must be acquired when accessing |delegate_|.
56 base::Lock lock_; 56 base::Lock lock_;
57 Delegate* delegate_; 57 Delegate* delegate_;
58 58
59 DISALLOW_COPY_AND_ASSIGN(PluginMessageLoopProxy); 59 DISALLOW_COPY_AND_ASSIGN(PluginThreadTaskRunner);
60 }; 60 };
61 61
62 } // namespace remoting 62 } // namespace remoting
63 63
64 #endif // REMOTING_BASE_PLUGIN_MESSAGE_LOOP_H_ 64 #endif // REMOTING_BASE_PLUGIN_THREAD_TASK_RUNNER_H_
OLDNEW
« no previous file with comments | « remoting/base/plugin_message_loop_proxy.cc ('k') | remoting/base/plugin_thread_task_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698