Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: chrome/browser/media_gallery/media_device_notifications_chromeos.cc

Issue 10830003: Extract and dispatch device uuid in media device attached notification message. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: '' Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // chromeos::MediaDeviceNotifications implementation. 5 // chromeos::MediaDeviceNotifications implementation.
6 6
7 #include "chrome/browser/media_gallery/media_device_notifications_chromeos.h" 7 #include "chrome/browser/media_gallery/media_device_notifications_chromeos.h"
8 8
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/metrics/histogram.h"
11 #include "base/stl_util.h" 12 #include "base/stl_util.h"
12 #include "base/string_number_conversions.h" 13 #include "base/string_number_conversions.h"
13 #include "base/utf_string_conversions.h" 14 #include "base/utf_string_conversions.h"
14 #include "chrome/browser/media_gallery/media_device_notifications_utils.h" 15 #include "chrome/browser/media_gallery/media_device_notifications_utils.h"
15 #include "content/public/browser/browser_thread.h" 16 #include "content/public/browser/browser_thread.h"
16 17
17 namespace chromeos { 18 namespace chromeos {
18 19
19 using content::BrowserThread; 20 using content::BrowserThread;
20 21
21 MediaDeviceNotifications::MediaDeviceNotifications() 22 MediaDeviceNotifications::MediaDeviceNotifications() {
22 : current_device_id_(0) {
23 DCHECK(disks::DiskMountManager::GetInstance()); 23 DCHECK(disks::DiskMountManager::GetInstance());
24 disks::DiskMountManager::GetInstance()->AddObserver(this); 24 disks::DiskMountManager::GetInstance()->AddObserver(this);
25 } 25 }
26 26
27 MediaDeviceNotifications::~MediaDeviceNotifications() { 27 MediaDeviceNotifications::~MediaDeviceNotifications() {
28 disks::DiskMountManager* manager = disks::DiskMountManager::GetInstance(); 28 disks::DiskMountManager* manager = disks::DiskMountManager::GetInstance();
29 if (manager) { 29 if (manager) {
30 manager->RemoveObserver(this); 30 manager->RemoveObserver(this);
31 } 31 }
32 } 32 }
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 } 94 }
95 95
96 void MediaDeviceNotifications::AddMountedPathOnUIThread( 96 void MediaDeviceNotifications::AddMountedPathOnUIThread(
97 const disks::DiskMountManager::MountPointInfo& mount_info) { 97 const disks::DiskMountManager::MountPointInfo& mount_info) {
98 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 98 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
99 99
100 if (ContainsKey(mount_map_, mount_info.mount_path)) { 100 if (ContainsKey(mount_map_, mount_info.mount_path)) {
101 NOTREACHED(); 101 NOTREACHED();
102 return; 102 return;
103 } 103 }
104 const std::string device_id_str = base::IntToString(current_device_id_++); 104
105 // Get the media device uuid if exists.
Ben Chan 2012/07/26 17:11:18 nit: perhaps turning 105 - 114 into method
kmadhusu 2012/07/26 17:23:05 Done.
106 const disks::DiskMountManager::DiskMap& disks =
107 disks::DiskMountManager::GetInstance()->disks();
108 disks::DiskMountManager::DiskMap::const_iterator it =
109 disks.find(mount_info.source_path);
110 std::string device_id_str;
111 if (it != disks.end()) {
112 const disks::DiskMountManager::Disk& disk = *it->second;
113 device_id_str = disk.fs_uuid();
114 }
115
116 // Keep track of device uuid, to see how often we receive empty uuid values.
117 static base::Histogram* media_device_uuid_available(NULL);
118 if (!media_device_uuid_available) {
119 media_device_uuid_available = base::BooleanHistogram::FactoryGet(
120 "MediaDeviceNotification.device_uuid_available",
121 base::Histogram::kUmaTargetedHistogramFlag);
122 }
123 media_device_uuid_available->AddBoolean(!device_id_str.empty());
124 if (device_id_str.empty())
125 return;
126
105 mount_map_.insert(std::make_pair(mount_info.mount_path, device_id_str)); 127 mount_map_.insert(std::make_pair(mount_info.mount_path, device_id_str));
106 base::SystemMonitor::Get()->ProcessMediaDeviceAttached( 128 base::SystemMonitor::Get()->ProcessMediaDeviceAttached(
107 device_id_str, 129 device_id_str,
108 UTF8ToUTF16(FilePath(mount_info.source_path).BaseName().value()), 130 UTF8ToUTF16(FilePath(mount_info.source_path).BaseName().value()),
109 base::SystemMonitor::TYPE_PATH, 131 base::SystemMonitor::TYPE_PATH,
110 mount_info.mount_path); 132 mount_info.mount_path);
111 } 133 }
112 134
113 } // namespace chrome 135 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/media_gallery/media_device_notifications_chromeos.h ('k') | chromeos/dbus/cros_disks_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698