Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: remoting/host/chromoting_host_context.cc

Issue 10829467: [Chromoting] Introducing refcount-based life time management of the message loops in the service (d… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feedback and a unit test for AutoThreadTaskRunner. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/host/chromoting_host_context.h" 5 #include "remoting/host/chromoting_host_context.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/threading/thread.h" 10 #include "base/threading/thread.h"
11 #include "remoting/base/auto_thread_task_runner.h"
11 #include "remoting/host/url_request_context.h" 12 #include "remoting/host/url_request_context.h"
12 13
13 namespace remoting { 14 namespace remoting {
14 15
15 ChromotingHostContext::ChromotingHostContext( 16 ChromotingHostContext::ChromotingHostContext(
16 scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner) 17 scoped_refptr<AutoThreadTaskRunner> ui_task_runner)
17 : network_thread_("ChromotingNetworkThread"), 18 : network_thread_("ChromotingNetworkThread"),
18 capture_thread_("ChromotingCaptureThread"), 19 capture_thread_("ChromotingCaptureThread"),
19 encode_thread_("ChromotingEncodeThread"), 20 encode_thread_("ChromotingEncodeThread"),
20 desktop_thread_("ChromotingDesktopThread"), 21 desktop_thread_("ChromotingDesktopThread"),
21 file_thread_("ChromotingFileIOThread"), 22 file_thread_("ChromotingFileIOThread"),
22 ui_task_runner_(ui_task_runner) { 23 ui_task_runner_(ui_task_runner) {
23 } 24 }
24 25
25 ChromotingHostContext::~ChromotingHostContext() { 26 ChromotingHostContext::~ChromotingHostContext() {
26 } 27 }
27 28
28 bool ChromotingHostContext::Start() { 29 bool ChromotingHostContext::Start() {
29 // Start all the threads. 30 // Start all the threads.
30 bool started = capture_thread_.Start() && encode_thread_.Start() && 31 bool started = capture_thread_.Start() && encode_thread_.Start() &&
31 network_thread_.StartWithOptions(base::Thread::Options( 32 network_thread_.StartWithOptions(base::Thread::Options(
32 MessageLoop::TYPE_IO, 0)) && 33 MessageLoop::TYPE_IO, 0)) &&
33 desktop_thread_.Start() && 34 desktop_thread_.Start() &&
34 file_thread_.StartWithOptions( 35 file_thread_.StartWithOptions(
35 base::Thread::Options(MessageLoop::TYPE_IO, 0)); 36 base::Thread::Options(MessageLoop::TYPE_IO, 0));
36 if (!started) 37 if (!started)
37 return false; 38 return false;
38 39
40 // Wrap worker threads with |AutoThreadTaskRunner| and have them reference
41 // the main thread via |ui_task_runner_|, to ensure that it remain active to
42 // Stop() them when no references remain.
43 network_task_runner_ =
44 new AutoThreadTaskRunner(network_thread_.message_loop_proxy(),
45 ui_task_runner_);
46 capture_task_runner_ =
47 new AutoThreadTaskRunner(capture_thread_.message_loop_proxy(),
48 ui_task_runner_);
49 encode_task_runner_ =
50 new AutoThreadTaskRunner(encode_thread_.message_loop_proxy(),
51 ui_task_runner_);
52 desktop_task_runner_ =
53 new AutoThreadTaskRunner(desktop_thread_.message_loop_proxy(),
54 ui_task_runner_);
55 file_task_runner_ =
56 new AutoThreadTaskRunner(file_thread_.message_loop_proxy(),
57 ui_task_runner_);
58
39 url_request_context_getter_ = new URLRequestContextGetter( 59 url_request_context_getter_ = new URLRequestContextGetter(
40 ui_task_runner(), network_task_runner(), 60 ui_task_runner(), network_task_runner(),
41 static_cast<MessageLoopForIO*>(file_thread_.message_loop())); 61 static_cast<MessageLoopForIO*>(file_thread_.message_loop()));
42 return true; 62 return true;
43 } 63 }
44 64
65 void ChromotingHostContext::ReleaseTaskRunners() {
66 url_request_context_getter_ = NULL;
67 network_task_runner_ = NULL;
68 capture_task_runner_ = NULL;
69 encode_task_runner_ = NULL;
70 desktop_task_runner_ = NULL;
71 file_task_runner_ = NULL;
72 ui_task_runner_ = NULL;
73 }
74
45 base::SingleThreadTaskRunner* ChromotingHostContext::capture_task_runner() { 75 base::SingleThreadTaskRunner* ChromotingHostContext::capture_task_runner() {
46 return capture_thread_.message_loop_proxy(); 76 return capture_task_runner_;
47 } 77 }
48 78
49 base::SingleThreadTaskRunner* ChromotingHostContext::encode_task_runner() { 79 base::SingleThreadTaskRunner* ChromotingHostContext::encode_task_runner() {
50 return encode_thread_.message_loop_proxy(); 80 return encode_task_runner_;
51 } 81 }
52 82
53 base::SingleThreadTaskRunner* ChromotingHostContext::network_task_runner() { 83 base::SingleThreadTaskRunner* ChromotingHostContext::network_task_runner() {
54 return network_thread_.message_loop_proxy(); 84 return network_task_runner_;
55 } 85 }
56 86
57 base::SingleThreadTaskRunner* ChromotingHostContext::desktop_task_runner() { 87 base::SingleThreadTaskRunner* ChromotingHostContext::desktop_task_runner() {
58 return desktop_thread_.message_loop_proxy(); 88 return desktop_task_runner_;
59 } 89 }
60 90
61 base::SingleThreadTaskRunner* ChromotingHostContext::ui_task_runner() { 91 base::SingleThreadTaskRunner* ChromotingHostContext::ui_task_runner() {
62 return ui_task_runner_; 92 return ui_task_runner_;
63 } 93 }
64 94
65 base::SingleThreadTaskRunner* ChromotingHostContext::file_task_runner() { 95 base::SingleThreadTaskRunner* ChromotingHostContext::file_task_runner() {
66 return file_thread_.message_loop_proxy(); 96 return file_task_runner_;
67 } 97 }
68 98
69 const scoped_refptr<net::URLRequestContextGetter>& 99 const scoped_refptr<net::URLRequestContextGetter>&
70 ChromotingHostContext::url_request_context_getter() { 100 ChromotingHostContext::url_request_context_getter() {
71 DCHECK(url_request_context_getter_.get()); 101 DCHECK(url_request_context_getter_.get());
72 return url_request_context_getter_; 102 return url_request_context_getter_;
73 } 103 }
74 104
75 } // namespace remoting 105 } // namespace remoting
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698