Auto select the connection tab of the Website Settings UI in case of an https error or mixed content

chrome/browser/ui/website_settings/website_settings.cc

Index: chrome/browser/ui/website_settings/website_settings.cc
diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc
index 4d24a45e6ed124306d14170ce6672d7ba8a8990c..a1cd5362a7fca863d82c6c526654986688d8bce8 100644
--- a/chrome/browser/ui/website_settings/website_settings.cc
+++ b/chrome/browser/ui/website_settings/website_settings.cc
@@ -411,6 +411,20 @@ void WebsiteSettings::Init(Profile* profile,
           IDS_PAGE_INFO_SECURITY_TAB_RENEGOTIATION_MESSAGE);
     }
   }
+
+  // By default select the permissions tab that displays all the site
+  // permissions. In case of a connection error or an issue with the
+  // certificate presented by the website select the connection tab to draw to
+  // users attention to the issue.  If the site does not provide a certificate
+  // because it was loaded over an unencrypted connection, don't select the
+  // connection tab.
+  WebsiteSettingsUI::TabId tab_id = WebsiteSettingsUI::TAB_ID_PERMISSIONS;
+  if (site_connection_status_ == SITE_CONNECTION_STATUS_ENCRYPTED_ERROR ||
+      site_connection_status_ == SITE_CONNECTION_STATUS_MIXED_CONTENT ||
+      site_identity_status_ == SITE_IDENTITY_STATUS_ERROR ||
+      site_identity_status_ == SITE_IDENTITY_STATUS_CERT_REVOCATION_UNKNOWN)

[markusheintz_, 2012/08/21 17:07:07]

@wtc: I'm not sure if we should check for the revocation status here. I remember
a post from Scott Violet (http://www.imperialviolet.org/2012/02/05/crlsets.html)
where he discussed cert revocation checks. So I wonder whether I'm not better
off removing this check.

+    tab_id = WebsiteSettingsUI::TAB_ID_CONNECTION;
+  ui_->SetSelectedTab(tab_id);
 }
 
 void WebsiteSettings::PresentSitePermissions() {