Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: chrome/browser/ui/website_settings/website_settings_ui.h

Issue 10829452: Auto select the connection tab of the Website Settings UI in case of an https error or mixed content (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix build issues. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/website_settings_ui.h
diff --git a/chrome/browser/ui/website_settings/website_settings_ui.h b/chrome/browser/ui/website_settings/website_settings_ui.h
index e159df08344b2f23f6946ab054c4c67b5f5add4a..e3162890a4e296808ab603cb26747becaabf34da 100644
--- a/chrome/browser/ui/website_settings/website_settings_ui.h
+++ b/chrome/browser/ui/website_settings/website_settings_ui.h
@@ -37,8 +37,9 @@ class WebsiteSettingsUI {
// The Website Settings UI contains several tabs. Each tab is assiciated with
// a unique tab id. The enum |TabId| contains all the ids for the tabs.
enum TabId {
- TAB_ID_PERMISSIONS,
+ TAB_ID_PERMISSIONS = 0,
TAB_ID_CONNECTION,
+ NUM_TAB_IDS,
};
// |CookieInfo| contains information about the cookies from a specific source.
@@ -142,9 +143,7 @@ class WebsiteSettingsUI {
virtual void SetFirstVisit(const string16& first_visit) = 0;
// Selects the tab with the given |tab_id|.
- // TODO(markusheintz): Implement this on other platforms and make it a pure
- // virtual function.
- virtual void SetSelectedTab(TabId tab_id) {}
+ virtual void SetSelectedTab(TabId tab_id) = 0;
};
typedef WebsiteSettingsUI::CookieInfoList CookieInfoList;

Powered by Google App Engine
This is Rietveld 408576698