chrome/browser/ui/views/website_settings/website_settings_popup_view.h - Issue 10829452: Auto select the connection tab of the Website Settings UI in case of an https error or mixed content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

Issue 10829452: Auto select the connection tab of the Website Settings UI in case of an https error or mixed content (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments and really upload the CL :) Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc ('k') | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('j') | chrome/browser/ui/views/website_settings/website_settings_popup_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.h

diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

index 0c298dc7961523c485f6f48e52a80fd57f5e9ccf..067711ca7a2d96803094e3104d7ec03e5422d3b8 100644

--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h

@@ -82,6 +82,7 @@ class WebsiteSettingsPopupView

const PermissionInfoList& permission_info_list) OVERRIDE;

virtual void SetIdentityInfo(const IdentityInfo& identity_info) OVERRIDE;

virtual void SetFirstVisit(const string16& first_visit) OVERRIDE;

+ virtual void SetSelectedTab(TabId tab_id) OVERRIDE;

// Creates the contents of the "Permissions" tab. The ownership of the

// returned view is transferred to the caller.

@@ -122,6 +123,8 @@ class WebsiteSettingsPopupView

// The |TabbedPane| that contains the tabs of the Website Settings UI.

views::TabbedPane* tabbed_pane_;

+ // The view that contains the connection tab contents.

+ views::View* connection_tab_;

// The view that contains the contents of the "Cookies and Site data" section

// from the "Permissions" tab.