Issue 10829368: fix gdbjit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829368: fix gdbjit (Closed)

Created:
8 years, 4 months ago by bnoordhuis1

Modified:
8 years, 1 month ago

Reviewers:

CC:
v8-dev

Visibility:
Public.

Description

fix gdbjit * update to current V8 API * use zone based memory management * fix -Werror=overloaded-virtual errors, rename methods

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -76 lines)			Patch
M	src/gdb-jit.cc	View	23 chunks	+96 lines, -68 lines	1 comment	Download
M	src/mark-compact.cc	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

noordhuis

8 years, 4 months ago (2012-08-17 01:28:39 UTC) #1

http://codereview.chromium.org/10829368/diff/1/src/gdb-jit.cc
File src/gdb-jit.cc (right):

http://codereview.chromium.org/10829368/diff/1/src/gdb-jit.cc#newcode2095
src/gdb-jit.cc:2095: Zone* zone = Isolate::Current()->runtime_zone();
I suspect that it's better to create a new zone and tie it to the life cycle of
the JITCodeEntry but I'm not sure what the best approach is. Simply new and
delete it?

Expand Messages | Collapse Messages