Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: ui/base/clipboard/clipboard_unittest.cc

Issue 10829341: Desktop aura: Use the X11 clipboard (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix MessageLoop ordering in tests. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/clipboard/clipboard_chromeos.cc ('k') | ui/base/x/x11_atom_cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/clipboard/clipboard_unittest.cc
diff --git a/ui/base/clipboard/clipboard_unittest.cc b/ui/base/clipboard/clipboard_unittest.cc
index 1653313edb99244ba077ba4404dc778e19b00404..e8b3d39665348fec2eda434146d67e3bf04db46f 100644
--- a/ui/base/clipboard/clipboard_unittest.cc
+++ b/ui/base/clipboard/clipboard_unittest.cc
@@ -27,6 +27,10 @@
#include "base/android/jni_android.h"
#endif
+#if defined(OS_WIN) || defined(USE_AURA)
+#include "base/message_loop.h"
+#endif
+
namespace ui {
class ClipboardTest : public PlatformTest {
@@ -318,6 +322,8 @@ TEST_F(ClipboardTest, URLTest) {
#endif
}
+// TODO(erg): Reenable this everywhere once linux_aura learns what bitmaps are.
+#if !(defined(USE_AURA) && !defined(OS_CHROMEOS))
TEST_F(ClipboardTest, SharedBitmapTest) {
unsigned int fake_bitmap[] = {
0x46155189, 0xF6A55C8D, 0x79845674, 0xFA57BD89,
@@ -359,11 +365,16 @@ TEST_F(ClipboardTest, SharedBitmapTest) {
EXPECT_TRUE(clipboard().IsFormatAvailable(Clipboard::GetBitmapFormatType(),
Clipboard::BUFFER_STANDARD));
}
+#endif
// The following test somehow fails on GTK. The image when read back from the
// clipboard has the alpha channel set to 0xFF for some reason. The other
// channels stay intact. So I am turning this on only for aura.
-#if (defined(USE_AURA) && !defined(OS_WIN)) || defined(OS_ANDROID)
+//
+// TODO(erg): This also crashes in linux_aura. Investigate once bitmap writing
+// is implemented.
+#if (defined(USE_AURA) && !(defined(OS_WIN) || !defined(OS_CHROMEOS))) || \
+ defined(OS_ANDROID)
TEST_F(ClipboardTest, MultipleBitmapReadWriteTest) {
// Test first bitmap
unsigned int fake_bitmap_1[] = {
« no previous file with comments | « ui/base/clipboard/clipboard_chromeos.cc ('k') | ui/base/x/x11_atom_cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698