Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: ui/base/clipboard/clipboard.h

Issue 10829341: Desktop aura: Use the X11 clipboard (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix MessageLoop ordering in tests. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/x11_atom_cache.cc ('k') | ui/base/clipboard/clipboard_aurax11.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/clipboard/clipboard.h
diff --git a/ui/base/clipboard/clipboard.h b/ui/base/clipboard/clipboard.h
index 18463da7472806a860d8faf7b3abc229c4933416..83891b08c261ae17b3a257e676f718233a27b5cb 100644
--- a/ui/base/clipboard/clipboard.h
+++ b/ui/base/clipboard/clipboard.h
@@ -29,6 +29,10 @@
#include "base/android/scoped_java_ref.h"
#endif
+#if defined(USE_AURA) && defined(USE_X11)
+#include "base/memory/scoped_ptr.h"
+#endif
+
namespace gfx {
class Size;
}
@@ -93,7 +97,9 @@ class UI_EXPORT Clipboard : NON_EXPORTED_BASE(public base::ThreadChecker) {
NSString* data_;
#elif defined(USE_AURA)
explicit FormatType(const std::string& native_format);
+ public:
const std::string& ToString() const { return data_; }
+ private:
std::string data_;
#elif defined(TOOLKIT_GTK)
explicit FormatType(const std::string& native_format);
@@ -209,10 +215,11 @@ class UI_EXPORT Clipboard : NON_EXPORTED_BASE(public base::ThreadChecker) {
// On Linux/BSD, we need to know when the clipboard is set to a URL. Most
// platforms don't care.
-#if defined(OS_WIN) || defined(OS_MACOSX) || defined(USE_AURA) \
+#if defined(OS_WIN) || defined(OS_MACOSX) \
+ || (defined(USE_AURA) && defined(OS_CHROMEOS)) \
|| defined(OS_ANDROID)
void DidWriteURL(const std::string& utf8_text) {}
-#else // !defined(OS_WIN) && !defined(OS_MACOSX)
+#else
void DidWriteURL(const std::string& utf8_text);
#endif
@@ -375,6 +382,12 @@ class UI_EXPORT Clipboard : NON_EXPORTED_BASE(public base::ThreadChecker) {
TargetMap* clipboard_data_;
GtkClipboard* clipboard_;
GtkClipboard* primary_selection_;
+#elif defined(USE_AURA) && defined(USE_X11) && !defined(OS_CHROMEOS)
+ private:
+ // We keep our implementation details private because otherwise we bring in
+ // the X11 headers and break chrome compile.
+ class AuraX11Details;
+ scoped_ptr<AuraX11Details> aurax11_details_;
#endif
DISALLOW_COPY_AND_ASSIGN(Clipboard);
« no previous file with comments | « ui/aura/x11_atom_cache.cc ('k') | ui/base/clipboard/clipboard_aurax11.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698