remoting/host/me2me_preference_pane-Info.plist - Issue 10829327: [Chromoting] Cleanup branding variables in Chromoting gyp file.

Side by Side Diff: remoting/host/me2me_preference_pane-Info.plist

Issue 10829327: [Chromoting] Cleanup branding variables in Chromoting gyp file. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist ('K') | « remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist ('k') | remoting/host/plugin/constants.h » ('j') | remoting/remoting.gyp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="UTF-8"?>	1 <?xml version="1.0" encoding="UTF-8"?>

2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">	2 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/ PropertyList-1.0.dtd">

3 <plist version="1.0">	3 <plist version="1.0">

4 <dict>	4 <dict>

5 <key>CFBundleDevelopmentRegion</key>	5 <key>CFBundleDevelopmentRegion</key>
	alexeypa (please no reviews) 2012/08/14 23:50:51 nit: I think we prefer 2 character wide indent. nit: I think we prefer 2 character wide indent. garykac 2012/08/17 18:47:26 Auto-generated tab. Show quoted text On 2012/08/14 23:50:51, alexeypa wrote: > nit: I think we prefer 2 character wide indent. Auto-generated tab.
6 <string>English</string>	6 <string>English</string>

7 <key>CFBundleExecutable</key>	7 <key>CFBundleExecutable</key>

8 <string>${EXECUTABLE_NAME}</string>	8 <string>${EXECUTABLE_NAME}</string>

9 <key>CFBundleIconFile</key>	9 <key>CFBundleIconFile</key>

10 <string></string>	10 <string></string>

11 <key>CFBundleIdentifier</key>	11 <key>CFBundleIdentifier</key>

12 <string>BUNDLE_ID</string>	12 <string>BUNDLE_ID</string>

13 <key>CFBundleInfoDictionaryVersion</key>	13 <key>CFBundleInfoDictionaryVersion</key>

14 <string>6.0</string>	14 <string>6.0</string>

15 <key>CFBundleName</key>	15 <key>CFBundleName</key>

16 <string>BUNDLE_NAME</string>	16 <string>BUNDLE_NAME</string>

17 <key>CFBundlePackageType</key>	17 <key>CFBundlePackageType</key>

18 <string>BNDL</string>	18 <string>BNDL</string>

19 <key>CFBundleShortVersionString</key>	19 <key>CFBundleShortVersionString</key>

20 <string>VERSION_SHORT</string>	20 <string>VERSION_SHORT</string>

21 <key>CFBundleSignature</key>	21 <key>CFBundleSignature</key>

22 <string>????</string>	22 <string>????</string>

23 <key>CFBundleVersion</key>	23 <key>CFBundleVersion</key>

24 <string>VERSION_FULL</string>	24 <string>VERSION_FULL</string>

25 <key>NSHumanReadableCopyright</key>	25 <key>NSHumanReadableCopyright</key>

26 » <string>Copyright © 2012 COPYRIGHT_BY All rights reserved.</string>	26 » <string>COPYRIGHT_INFO</string>
	alexeypa (please no reviews) 2012/08/14 23:50:51 nit: tab -> space nit: tab -> space garykac 2012/08/17 18:47:26 Tabs are everywhere in this file (not just this on Show quoted text On 2012/08/14 23:50:51, alexeypa wrote: > nit: tab -> space Tabs are everywhere in this file (not just this one line).
27 <key>NSMainNibFile</key>	27 <key>NSMainNibFile</key>

28 <string>me2me_preference_pane</string>	28 <string>me2me_preference_pane</string>

29 <key>NSPrefPaneIconFile</key>	29 <key>NSPrefPaneIconFile</key>

30 <string>chromoting128.png</string>	30 <string>chromoting128.png</string>

31 <key>NSPrefPaneIconLabel</key>	31 <key>NSPrefPaneIconLabel</key>

32 <string>PREF_PANE_ICON_LABEL</string>	32 <string>PREF_PANE_ICON_LABEL</string>

33 <key>NSPrincipalClass</key>	33 <key>NSPrincipalClass</key>

34 <string>Me2MePreferencePane</string>	34 <string>Me2MePreferencePane</string>

35 </dict>	35 </dict>

36 </plist>	36 </plist>

OLD	NEW