Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: remoting/protocol/name_value_map.h

Issue 10829324: Add mux-stream transport support in session description (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/name_value_map.h
diff --git a/remoting/protocol/name_value_map.h b/remoting/protocol/name_value_map.h
new file mode 100644
index 0000000000000000000000000000000000000000..d5e86b4143bc06a3721589b6aedb48c2b77c248f
--- /dev/null
+++ b/remoting/protocol/name_value_map.h
@@ -0,0 +1,39 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Helper functions that allow to map enum values to strings.
+
+namespace remoting {
+namespace protocol {
+
+template <typename T>
+struct NameMapElement {
Wez 2012/08/14 20:56:32 nit: If you make both |value| and |name| template
Sergey Ulanov 2012/08/14 21:21:36 We need to store char* in the static array (to avo
+ const T value;
+ const char* const name;
+};
+
+template <typename T, size_t N>
+const char* ValueToName(const NameMapElement<T> (&map)[N], T value) {
+ for (size_t i = 0; i < N; ++i) {
+ if (map[i].value == value)
+ return map[i].name;
+ }
+ return NULL;
+}
+
+template <typename T, size_t N>
+bool NameToValue(const NameMapElement<T> (&map)[N],
+ const std::string& name,
+ T* result) {
Wez 2012/08/14 20:56:32 nit: Why not return const T* and have the caller c
Sergey Ulanov 2012/08/14 21:21:36 I think that would be more confusing and harder to
+ for (size_t i = 0; i < N; ++i) {
+ if (map[i].name == name) {
+ *result = map[i].value;
+ return true;
+ }
+ }
+ return false;
+}
+
+} // namespace protocol
+} // namespace remoting

Powered by Google App Engine
This is Rietveld 408576698