Issue 10829323: Fixing problem with not showing bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829323: Fixing problem with not showing bubble (Closed)

Created:
8 years, 4 months ago by Mr4D (OOO till 08-26)

Modified:
8 years, 4 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixing problem with not showing bubble BUG=142355 TEST=visual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151704

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed the underlying activation problem #

Patch Set 3 : Reverted comment #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	ui/views/widget/root_view.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Mr4D (OOO till 08-26)

We might want to re-visit this later on - but at least for R22 this ...

8 years, 4 months ago (2012-08-14 18:39:04 UTC) #1

sky

Won't this cause the bubble to appear right after dismissed and the mouse moves? http://codereview.chromium.org/10829323/diff/1/ash/wm/workspace/frame_maximize_button.cc ...

8 years, 4 months ago (2012-08-14 20:11:38 UTC) #2

Mr4D (OOO till 08-26)

Addressed by finding the real cause. Will write a unit test tomorrow as a separate ...

8 years, 4 months ago (2012-08-15 03:04:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/10829323/5002

8 years, 4 months ago (2012-08-15 14:24:52 UTC) #5

Change committed as 151704

Expand Messages | Collapse Messages