Add a function to provide the list of third-party directories which are incompatible with Android

android_webview/tools/webview_licenses.py

Index: android_webview/tools/webview_licenses.py
diff --git a/android_webview/tools/webview_licenses.py b/android_webview/tools/webview_licenses.py
index e15e164cb9a007a93bd958a6b8b6a853c310ecac..9e766dc77629057fa46076b543b14a804da757ae 100755
--- a/android_webview/tools/webview_licenses.py
+++ b/android_webview/tools/webview_licenses.py
@@ -31,6 +31,40 @@ sys.path.append(os.path.join(REPOSITORY_ROOT, 'tools'))
 import licenses
 
 
+def GetIncompatibleDirectories():
+  """Gets a list of third-party directories which use licenses incompatible
+  with Android. This is used by the snapshot tool.
+  Returns:
+    A list of directories.
+  """
+
+  whitelist = [
+    'Apache( Version)? 2(\.0)?',
+    '(New )?BSD( 3-Clause)?( with advertising clause)?',
+    'L?GPL ?v?2(\.[01])?( or later)?',

[Nico, 2012/08/10 00:36:48]

You're whitelisting GPL?

[Steve Block, 2012/08/10 07:55:22]

GPL v2, yes. While we can't include GPL v2 code in the binary, it is compatible
with Android licensing requirements, so it's OK to include it in the Android
tree. Incompatibly licensed code is excluded from the snapshot in the Android
tree.

+    'MIT(/X11)?(-like)?',
+    'MPL 1\.1 ?/ ?GPL 2(\.0)? ?/ ?LGPL 2\.1',
+    'Microsoft Limited Public License',
+    'Microsoft Permissive License',
+    'Public Domain',
+    'SGI Free Software License B',
+    'X11',
+  ]
+  regex = '^(%s)$' % '|'.join(whitelist)
+  result = []
+  for directory in _FindThirdPartyDirs():
+    metadata = licenses.ParseDir(directory)
+    if metadata.get('Android Compatibility', 'no') == 'yes':

[Nico, 2012/08/10 16:42:16]

nit: "Android Compatibility: yes" reads weird to me. I'd say "Android
Compatible: yes", or even "License Android Compatible: yes" (which is more
explicit). But that's bikeshedding, so feel free to ignore.

+      continue
+    license = re.split(' [Ll]icenses?$', metadata['License'])[0]
+    tokens = [x.strip() for x in re.split(' and |,', license) if len(x) > 0]
+    for token in tokens:
+      if not re.match(regex, token, re.IGNORECASE):
+        result.append(directory)
+        break
+  return result
+
+
 def _CheckLicenseHeaders(directory_list, whitelisted_files):
   """Checks that all files which are not in a listed third-party directory,
   and which do not use the standard Chromium license, are whitelisted.