Add a function to provide the list of third-party directories which are incompatible with Android

android_webview/tools/webview_licenses.py

 #!/usr/bin/python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Checks third-party licenses for the purposes of the Android WebView build.
 
 The Android tree includes a snapshot of Chromium in order to power the system
 WebView.  This tool checks that all code uses open-source licenses compatible
 with Android, and that we meet the requirements of those licenses. It can also
@@ skipping 13 matching lines @@
 import textwrap
 
 
 REPOSITORY_ROOT = os.path.abspath(os.path.join(
     os.path.dirname(__file__), '..', '..'))
 
 sys.path.append(os.path.join(REPOSITORY_ROOT, 'tools'))
 import licenses
 
 
+def GetIncompatibleDirectories():
+  """Gets a list of third-party directories which use licenses incompatible
+  with Android. This is used by the snapshot tool.
+  Returns:
+    A list of directories.
+  """
+
+  whitelist = [
+    'Apache( Version)? 2(\.0)?',
+    '(New )?BSD( 3-Clause)?( with advertising clause)?',
+    'L?GPL ?v?2(\.[01])?( or later)?',

[Nico, 2012/08/10 00:36:48]

You're whitelisting GPL?

[Steve Block, 2012/08/10 07:55:22]

GPL v2, yes. While we can't include GPL v2 code in the binary, it is compatible
with Android licensing requirements, so it's OK to include it in the Android
tree. Incompatibly licensed code is excluded from the snapshot in the Android
tree.

+    'MIT(/X11)?(-like)?',
+    'MPL 1\.1 ?/ ?GPL 2(\.0)? ?/ ?LGPL 2\.1',
+    'Microsoft Limited Public License',
+    'Microsoft Permissive License',
+    'Public Domain',
+    'SGI Free Software License B',
+    'X11',
+  ]
+  regex = '^(%s)$' % '|'.join(whitelist)
+  result = []
+  for directory in _FindThirdPartyDirs():
+    metadata = licenses.ParseDir(directory)
+    if metadata.get('Android Compatibility', 'no') == 'yes':

[Nico, 2012/08/10 16:42:16]

nit: "Android Compatibility: yes" reads weird to me. I'd say "Android
Compatible: yes", or even "License Android Compatible: yes" (which is more
explicit). But that's bikeshedding, so feel free to ignore.

+      continue
+    license = re.split(' [Ll]icenses?$', metadata['License'])[0]
+    tokens = [x.strip() for x in re.split(' and |,', license) if len(x) > 0]
+    for token in tokens:
+      if not re.match(regex, token, re.IGNORECASE):
+        result.append(directory)
+        break
+  return result
+
+
 def _CheckLicenseHeaders(directory_list, whitelisted_files):
   """Checks that all files which are not in a listed third-party directory,
   and which do not use the standard Chromium license, are whitelisted.
   Args:
     directory_list: The list of directories.
     whitelisted_files: The whitelist of files.
   Returns:
     True if all files with non-standard license headers are whitelisted and the
     whitelist contains no stale entries, otherwise false.
   """
@@ skipping 168 matching lines @@
       return 1
   elif args[0] == 'notice':
     print _GenerateNoticeFile(print_warnings=False)
     return 0
 
   parser.print_help()
   return 1
 
 if __name__ == '__main__':
   sys.exit(main())