ash/wm/workspace/workspace_manager.cc - Issue 10829226: Fixing many problems around the maximize bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/workspace_manager.cc

Issue 10829226: Fixing many problems around the maximize bubble (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fixed build problem Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/workspace/workspace_manager.cc

diff --git a/ash/wm/workspace/workspace_manager.cc b/ash/wm/workspace/workspace_manager.cc

index aac67bc4c8ee16bbad91242e00161b40fd96d22c..ccbb4f97375a1a1114b601b492fd38314a38c1b1 100644

--- a/ash/wm/workspace/workspace_manager.cc

+++ b/ash/wm/workspace/workspace_manager.cc

@@ -151,7 +151,8 @@ WorkspaceWindowState WorkspaceManager::GetWindowState() const {

for (aura::Window::Windows::const_iterator i = windows.begin();

i != windows.end(); ++i) {

ui::Layer* layer = (*i)->layer();

- if (!layer->GetTargetVisibility() || layer->GetTargetOpacity() == 0.0f)

+ if (!layer->GetTargetVisibility() || layer->GetTargetOpacity() == 0.0f ||

+ wm::IsWindowMinimized(*i))

continue;

if (wm::IsWindowMaximized(*i)) {

// An untracked window may still be fullscreen so we keep iterating when