Fixing many problems around the maximize bubble

ash/wm/workspace/workspace_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/workspace/workspace_manager.h"
 
 #include <algorithm>
 
 #include "ash/screen_ash.h"
 #include "ash/shell.h"
@@ skipping 133 matching lines @@
     return WORKSPACE_WINDOW_STATE_DEFAULT;
 
   // TODO: this code needs to be made multi-display aware.
   gfx::Rect shelf_bounds(shelf_->GetIdealBounds());
   const aura::Window::Windows& windows(contents_view_->children());
   bool window_overlaps_launcher = false;
   bool has_maximized_window = false;
   for (aura::Window::Windows::const_iterator i = windows.begin();
        i != windows.end(); ++i) {
     ui::Layer* layer = (*i)->layer();
-    if (!layer->GetTargetVisibility() || layer->GetTargetOpacity() == 0.0f)
+    if (!layer->GetTargetVisibility() || layer->GetTargetOpacity() == 0.0f ||
+        wm::IsWindowMinimized(*i))

[sky, 2012/08/07 23:11:18]

minimized windows should be hidden. So, I'm not sure why this is needed.

[Mr4D (OOO till 08-26), 2012/08/08 01:02:28]

If the window is maximized and is transformed directly into the minimized state
this seems not to apply. It might be because of animations going on?

[sky, 2012/08/08 04:39:16]

The target visibility should be 0. Do you have a test case I can try?

[Mr4D (OOO till 08-26), 2012/08/08 14:26:46]

I debugged it and here is what I see:

GetLayerTargetVisibility(): true
GetTargetOpacity(): 1.0
IsWindowMinimized: true

Looking at the code I can see that
WorkspaceManager::SetVisibilityOfWorkspaceWindows
gets called with no active windows in the workspace. I can also see that the
window gets explicitly set to visible. I looked through the callstack but after
a while I realized that there are many dependencies I don't know yet and
changing there something seems dangerous.

But here is a clue: When first normalizing the window and then minimizing it
works. I assume that the changed order of calls with the also disappearing
bubble must confuse the state machine.

See the call stack at the time:

ash::internal::WorkspaceManager::GetWindowState() at workspace_manager.cc:159
0x7ffff16e363a	
ash::internal::WorkspaceController::GetWindowState() at
workspace_controller.cc:63 0x7ffff16d92ba	
ash::internal::ShelfLayoutManager::UpdateVisibilityState() at
shelf_layout_manager.cc:234 0x7ffff16bd92d	
ash::internal::WorkspaceManager::UpdateShelfVisibility() at
workspace_manager.cc:139 0x7ffff16e341f	
ash::internal::WorkspaceManager::SetActiveWorkspace() at
workspace_manager.cc:292 0x7ffff16e403e	
ash::internal::WorkspaceManager::RemoveWorkspace() at workspace_manager.cc:221
0x7ffff16e3b62	
ash::internal::Workspace::~Workspace() at workspace.cc:27 0x7ffff16e12d1	
ash::internal::MaximizedWorkspace::~MaximizedWorkspace() at
maximized_workspace.cc:26 0x7ffff16dc7be	
ash::internal::WorkspaceManager::CleanupWorkspace() at workspace_manager.cc:358
0x7ffff16e4507	
ash::internal::WorkspaceManager::RemoveWindow() at workspace_manager.cc:128
0x7ffff16e33b4	
ash::internal::WorkspaceLayoutManager::ShowStateChanged() at
workspace_layout_manager.cc:103 0x7ffff16e2b86	
ash::internal::BaseLayoutManager::OnWindowPropertyChanged() at
base_layout_manager.cc:148 0x7ffff169fa0e	
ash::internal::WorkspaceLayoutManager::OnWindowPropertyChanged() at
workspace_layout_manager.cc:89 0x7ffff16e2aea	
aura::Window::SetPropertyInternal() at window.cc:645 0x7ffff1d2bfaa	
aura::Window::SetProperty<ui::WindowShowState>() at window_property.h:87
0x7ffff1cfc3ae	
views::NativeWidgetAura::Minimize() at native_widget_aura.cc:574 0x7fffeb4ce946	
views::Widget::Minimize() at widget.cc:577 0x7fffeb4d577f	
ash::FrameMaximizeButton::Snap() at frame_maximize_button.cc:474 0x7ffff16db972	

You can come over - or I can tell you offline how to repro.

       continue;
     if (wm::IsWindowMaximized(*i)) {
       // An untracked window may still be fullscreen so we keep iterating when
       // we hit a maximized window.
       has_maximized_window = true;
     } else if (wm::IsWindowFullscreen(*i)) {
       return WORKSPACE_WINDOW_STATE_FULL_SCREEN;
     }
     if (!window_overlaps_launcher && (*i)->bounds().Intersects(shelf_bounds))
       window_overlaps_launcher = true;
@@ skipping 183 matching lines @@
   return workspace;
 }
 
 void WorkspaceManager::CleanupWorkspace(Workspace* workspace) {
   if (workspace->type() != Workspace::TYPE_MANAGED && workspace->is_empty())
     delete workspace;
 }
 
 }  // namespace internal
 }  // namespace ash