Browser Plugin: Add HTML5-like postMessage support

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 3887 matching lines @@
     if (frame->document().body().appendChild(element)) {
       WebFrame* subframe = WebFrame::fromFrameOwnerElement(element);
       if (subframe)
         CreateFrameTree(subframe, child);
     } else {
       LOG(ERROR) << "Failed to append created iframe element.";
     }
   }
 }
 
-WebKit::WebFrame* RenderViewImpl::GetFrameByMappedID(int frame_id) {
-  std::map<int, int>::iterator it = active_frame_id_map_.find(frame_id);
-  if (it == active_frame_id_map_.end())
-    return NULL;
-
-  return FindFrameByID(webview()->mainFrame(), it->second);
+WebKit::WebFrame* RenderViewImpl::GetFrameByMappedID(int remote_frame_id) {
+  std::map<int, int>::const_iterator it = active_frame_id_map_.begin();
+  for (; it != active_frame_id_map_.end(); ++it) {
+    if (it->second == remote_frame_id) {
+      return FindFrameByID(webview()->mainFrame(), it->first);
+    }
+  }
+  return NULL;
 }
 
 void RenderViewImpl::EnsureMediaStreamImpl() {
   if (!RenderThreadImpl::current())  // Will be NULL during unit tests.
     return;
 
 #if defined(ENABLE_WEBRTC)
   if (!media_stream_dispatcher_)
     media_stream_dispatcher_ = new MediaStreamDispatcher(this);
 
@@ skipping 260 matching lines @@
   params.target_process_id = target_process_id_;
   params.target_routing_id = target_routing_id_;
 
   std::map<int,int>::iterator it = active_frame_id_map_.find(
       targetFrame->identifier());
   if (it != active_frame_id_map_.end()) {
     params.target_frame_id = it->second;
   } else {
     params.target_frame_id = 0;
   }
-
   Send(new ViewHostMsg_RouteMessageEvent(routing_id_, params));
   return true;
 }
 
 void RenderViewImpl::willOpenSocketStream(
     WebSocketStreamHandle* handle) {
   SocketStreamHandleData::AddToHandle(handle, routing_id_);
 }
 
 WebKit::WebString RenderViewImpl::userAgentOverride(
@@ skipping 2085 matching lines @@
   return !!RenderThreadImpl::current()->compositor_thread();
 }
 
 void RenderViewImpl::OnJavaBridgeInit() {
   DCHECK(!java_bridge_dispatcher_);
 #if defined(ENABLE_JAVA_BRIDGE)
   java_bridge_dispatcher_ = new JavaBridgeDispatcher(this);
 #endif
 }
 
-void RenderViewImpl::OnUpdatedFrameTree(
+void RenderViewImpl::UpdateFrameTree(
     int process_id,
     int route_id,
     const std::string& frame_tree) {
   // We should only act on this message if we are swapped out.  It's possible
   // for this to happen due to races.
-  if (!is_swapped_out_)
-    return;
-
   base::DictionaryValue* frames = NULL;
   scoped_ptr<base::Value> tree(base::JSONReader::Read(frame_tree));
-  if (tree.get() && tree->IsType(base::Value::TYPE_DICTIONARY))
-    tree->GetAsDictionary(&frames);
+  if (tree.get() && tree->IsType(base::Value::TYPE_DICTIONARY)) {
+    if (!tree->GetAsDictionary(&frames))
+      return;
+  }
 
   updating_frame_tree_ = true;
   active_frame_id_map_.clear();
 
   target_process_id_ = process_id;
   target_routing_id_ = route_id;
   CreateFrameTree(webview()->mainFrame(), frames);
 
   updating_frame_tree_ = false;
 }
+
+void RenderViewImpl::OnUpdatedFrameTree(

[nasko, 2012/10/02 17:52:31]

This change might be worthwhile as a separate bug/CL. It is found through this,
but might be easier to account/search for later if it is done separately.

[Fady Samuel, 2012/10/02 22:04:08]

Done. Leaving it here until the other patch lands.

+    int process_id,
+    int route_id,
+    const std::string& frame_tree) {
+  if (!is_swapped_out_)
+    return;
+
+  if (frame_tree.empty())
+    return;
+  // Post the task to update the frame tree on the task queue to ensure that

[nasko, 2012/10/02 17:52:31]

nit: An empty line prior to the comment will make it a bit more readable.

+  // that any pending postMessage tasks are handled before the frame tree is
+  // updated. If we navigate between the time we schedule a postMessage, and
+  // the time we handle it, we will get a navigation that will prevent the
+  // message from being posted.
+  MessageLoop::current()->PostTask(
+      FROM_HERE,
+      base::Bind(&RenderViewImpl::UpdateFrameTree, AsWeakPtr(),
+          process_id, route_id, frame_tree));
+}